| Message ID | 20230913102656.2966757-1-chancel.liu@nxp.com |
|---|---|
| State | Accepted |
| Commit | fac58baf8fcfcd7481e8f6d60206ce2a47c1476c |
| Headers | show |
| Series | [v2] ASoC: imx-rpmsg: Set ignore_pmdown_time for dai_link | expand |
On Wed, Sep 13, 2023 at 6:27 PM Chancel Liu <chancel.liu@nxp.com> wrote: > > i.MX rpmsg sound cards work on codec slave mode. MCLK will be disabled > by CPU DAI driver in hw_free(). Some codec requires MCLK present at > power up/down sequence. So need to set ignore_pmdown_time to power down > codec immediately before MCLK is turned off. > > Take WM8962 as an example, if MCLK is disabled before DAPM power down > playback stream, FIFO error will arise in WM8962 which will have bad > impact on playback next. > > Signed-off-by: Chancel Liu <chancel.liu@nxp.com> Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> Best regards Wang Shengjiu > --- > sound/soc/fsl/imx-rpmsg.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c > index 3c7b95db2eac..b578f9a32d7f 100644 > --- a/sound/soc/fsl/imx-rpmsg.c > +++ b/sound/soc/fsl/imx-rpmsg.c > @@ -89,6 +89,14 @@ static int imx_rpmsg_probe(struct platform_device *pdev) > SND_SOC_DAIFMT_NB_NF | > SND_SOC_DAIFMT_CBC_CFC; > > + /* > + * i.MX rpmsg sound cards work on codec slave mode. MCLK will be > + * disabled by CPU DAI driver in hw_free(). Some codec requires MCLK > + * present at power up/down sequence. So need to set ignore_pmdown_time > + * to power down codec immediately before MCLK is turned off. > + */ > + data->dai.ignore_pmdown_time = 1; > + > /* Optional codec node */ > ret = of_parse_phandle_with_fixed_args(np, "audio-codec", 0, 0, &args); > if (ret) { > -- > 2.25.1 >
On Wed, 13 Sep 2023 18:26:56 +0800, Chancel Liu wrote: > i.MX rpmsg sound cards work on codec slave mode. MCLK will be disabled > by CPU DAI driver in hw_free(). Some codec requires MCLK present at > power up/down sequence. So need to set ignore_pmdown_time to power down > codec immediately before MCLK is turned off. > > Take WM8962 as an example, if MCLK is disabled before DAPM power down > playback stream, FIFO error will arise in WM8962 which will have bad > impact on playback next. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: imx-rpmsg: Set ignore_pmdown_time for dai_link commit: fac58baf8fcfcd7481e8f6d60206ce2a47c1476c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c index 3c7b95db2eac..b578f9a32d7f 100644 --- a/sound/soc/fsl/imx-rpmsg.c +++ b/sound/soc/fsl/imx-rpmsg.c @@ -89,6 +89,14 @@ static int imx_rpmsg_probe(struct platform_device *pdev) SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC; + /* + * i.MX rpmsg sound cards work on codec slave mode. MCLK will be + * disabled by CPU DAI driver in hw_free(). Some codec requires MCLK + * present at power up/down sequence. So need to set ignore_pmdown_time + * to power down codec immediately before MCLK is turned off. + */ + data->dai.ignore_pmdown_time = 1; + /* Optional codec node */ ret = of_parse_phandle_with_fixed_args(np, "audio-codec", 0, 0, &args); if (ret) {
i.MX rpmsg sound cards work on codec slave mode. MCLK will be disabled by CPU DAI driver in hw_free(). Some codec requires MCLK present at power up/down sequence. So need to set ignore_pmdown_time to power down codec immediately before MCLK is turned off. Take WM8962 as an example, if MCLK is disabled before DAPM power down playback stream, FIFO error will arise in WM8962 which will have bad impact on playback next. Signed-off-by: Chancel Liu <chancel.liu@nxp.com> --- sound/soc/fsl/imx-rpmsg.c | 8 ++++++++ 1 file changed, 8 insertions(+)