| Message ID | 20230921085752.8686-1-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: mux: gpio: adhere to coding style | expand |
2023-09-21 at 10:57, Wolfram Sang wrote: > Advertise our coding style by following it :) > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> A no-brainer... Acked-by: Peter Rosin <peda@axentia.se> Cheers, Peter > --- > drivers/i2c/muxes/i2c-mux-gpio.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c > index 5ca03bd34c8d..0419c7453281 100644 > --- a/drivers/i2c/muxes/i2c-mux-gpio.c > +++ b/drivers/i2c/muxes/i2c-mux-gpio.c > @@ -23,7 +23,7 @@ struct gpiomux { > struct gpio_desc **gpios; > }; > > -static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val) > +static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned int val) > { > DECLARE_BITMAP(values, BITS_PER_TYPE(val)); > > @@ -59,7 +59,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux, > struct device_node *adapter_np; > struct i2c_adapter *adapter = NULL; > struct fwnode_handle *child; > - unsigned *values; > + unsigned int *values; > int rc, i = 0; > > if (is_of_node(fwnode)) { > @@ -102,7 +102,6 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux, > device_for_each_child_node(dev, child) { > if (is_of_node(child)) { > fwnode_property_read_u32(child, "reg", values + i); > - > } else if (is_acpi_node(child)) { > rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i); > if (rc) { > @@ -127,7 +126,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) > struct gpiomux *mux; > struct i2c_adapter *parent; > struct i2c_adapter *root; > - unsigned initial_state; > + unsigned int initial_state; > int i, ngpios, ret; > > mux = devm_kzalloc(&pdev->dev, sizeof(*mux), GFP_KERNEL);
On Thu, Sep 21, 2023 at 10:57:51AM +0200, Wolfram Sang wrote: > Advertise our coding style by following it :) > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-next, thanks!
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 5ca03bd34c8d..0419c7453281 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -23,7 +23,7 @@ struct gpiomux { struct gpio_desc **gpios; }; -static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val) +static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned int val) { DECLARE_BITMAP(values, BITS_PER_TYPE(val)); @@ -59,7 +59,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux, struct device_node *adapter_np; struct i2c_adapter *adapter = NULL; struct fwnode_handle *child; - unsigned *values; + unsigned int *values; int rc, i = 0; if (is_of_node(fwnode)) { @@ -102,7 +102,6 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux, device_for_each_child_node(dev, child) { if (is_of_node(child)) { fwnode_property_read_u32(child, "reg", values + i); - } else if (is_acpi_node(child)) { rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i); if (rc) { @@ -127,7 +126,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) struct gpiomux *mux; struct i2c_adapter *parent; struct i2c_adapter *root; - unsigned initial_state; + unsigned int initial_state; int i, ngpios, ret; mux = devm_kzalloc(&pdev->dev, sizeof(*mux), GFP_KERNEL);
Advertise our coding style by following it :) Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/muxes/i2c-mux-gpio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)