| Message ID | 20230919124222.1155894-1-sebastian.reichel@collabora.com |
|---|---|
| State | Accepted |
| Commit | 383eba9f9a7f4cd639d367ea5daa6df2be392c54 |
| Headers | show |
| Series | power: supply: qcom_battmgr: fix battery_id type | expand |
+cc Johan Hovold who gave away that he is involved with this at Kernel Recipes :) On Tue, Sep 19, 2023 at 02:42:22PM +0200, Sebastian Reichel wrote: > qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() > and should be of type __le32, just like all other 32bit integer requests > for qcom_battmgr. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@intel.com/ > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > drivers/power/supply/qcom_battmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c > index de77df97b3a4..a05fd00711f6 100644 > --- a/drivers/power/supply/qcom_battmgr.c > +++ b/drivers/power/supply/qcom_battmgr.c > @@ -105,7 +105,7 @@ struct qcom_battmgr_property_request { > > struct qcom_battmgr_update_request { > struct pmic_glink_hdr hdr; > - u32 battery_id; > + __le32 battery_id; > }; > > struct qcom_battmgr_charge_time_request { > -- > 2.40.1 >
On Tue, Sep 19, 2023 at 02:42:22PM +0200, Sebastian Reichel wrote: > qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() > and should be of type __le32, just like all other 32bit integer requests > for qcom_battmgr. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@intel.com/ > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > drivers/power/supply/qcom_battmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c > index de77df97b3a4..a05fd00711f6 100644 > --- a/drivers/power/supply/qcom_battmgr.c > +++ b/drivers/power/supply/qcom_battmgr.c > @@ -105,7 +105,7 @@ struct qcom_battmgr_property_request { > > struct qcom_battmgr_update_request { > struct pmic_glink_hdr hdr; > - u32 battery_id; > + __le32 battery_id; > }; > > struct qcom_battmgr_charge_time_request { I can confirm that this addresses the corresponding sparse warnings: Reviewed-by: Johan Hovold <johan+linaro@kernel.org> I'll send a fix for the remaining warnings... Johan
On Fri, Sep 29, 2023 at 12:04:04PM +0200, Johan Hovold wrote: > On Tue, Sep 19, 2023 at 02:42:22PM +0200, Sebastian Reichel wrote: > > qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() > > and should be of type __le32, just like all other 32bit integer requests > > for qcom_battmgr. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@intel.com/ > > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") I think you should add Cc: stable@vger.kernel.org # 6.3 when applying as the robots may run sparse on the stable trees as well. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Johan
On Tue, 19 Sep 2023 14:42:22 +0200, Sebastian Reichel wrote: > qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() > and should be of type __le32, just like all other 32bit integer requests > for qcom_battmgr. > > Applied, thanks! [1/1] power: supply: qcom_battmgr: fix battery_id type commit: 383eba9f9a7f4cd639d367ea5daa6df2be392c54 Best regards,
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index de77df97b3a4..a05fd00711f6 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -105,7 +105,7 @@ struct qcom_battmgr_property_request { struct qcom_battmgr_update_request { struct pmic_glink_hdr hdr; - u32 battery_id; + __le32 battery_id; }; struct qcom_battmgr_charge_time_request {
qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() and should be of type __le32, just like all other 32bit integer requests for qcom_battmgr. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@intel.com/ Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- drivers/power/supply/qcom_battmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)