| Message ID | 20230927-rust-line-info-soundness-v1-3-990dce6f18ab@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On Wed, Sep 27, 2023 at 6:30 PM Erik Schilling <erik.schilling@linaro.org> wrote: > > Since the type changes around ownership of line_info instances are not > necessarily transparent to the user, we bump the major for the next > release of the crate. > > Note: > I am using the term "major" as defined in the Rust SemVer compatibility > guide [1], where the first non-zero digit is considered as "major". > > [1] https://doc.rust-lang.org/cargo/reference/semver.html > > Signed-off-by: Erik Schilling <erik.schilling@linaro.org> > --- > bindings/rust/libgpiod/Cargo.toml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml > index 518e5e5..3be4aa0 100644 > --- a/bindings/rust/libgpiod/Cargo.toml > +++ b/bindings/rust/libgpiod/Cargo.toml > @@ -4,7 +4,7 @@ > > [package] > name = "libgpiod" > -version = "0.1.0" > +version = "0.2.0" > authors = ["Viresh Kumar <viresh.kumar@linaro.org>"] > description = "libgpiod wrappers" > repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git" > > -- > 2.41.0 > Isn't it something that we should do right before tagging the release once we know the final requirement for the version change? At least this is what I do for the rest of libgpiod. Bart
On Fri Sep 29, 2023 at 2:43 PM CEST, Bartosz Golaszewski wrote: > On Wed, Sep 27, 2023 at 6:30 PM Erik Schilling > <erik.schilling@linaro.org> wrote: > > > > Since the type changes around ownership of line_info instances are not > > necessarily transparent to the user, we bump the major for the next > > release of the crate. > > > > Note: > > I am using the term "major" as defined in the Rust SemVer compatibility > > guide [1], where the first non-zero digit is considered as "major". > > > > [1] https://doc.rust-lang.org/cargo/reference/semver.html > > > > Signed-off-by: Erik Schilling <erik.schilling@linaro.org> > > --- > > bindings/rust/libgpiod/Cargo.toml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml > > index 518e5e5..3be4aa0 100644 > > --- a/bindings/rust/libgpiod/Cargo.toml > > +++ b/bindings/rust/libgpiod/Cargo.toml > > @@ -4,7 +4,7 @@ > > > > [package] > > name = "libgpiod" > > -version = "0.1.0" > > +version = "0.2.0" > > authors = ["Viresh Kumar <viresh.kumar@linaro.org>"] > > description = "libgpiod wrappers" > > repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git" > > > > -- > > 2.41.0 > > > > Isn't it something that we should do right before tagging the release > once we know the final requirement for the version change? At least > this is what I do for the rest of libgpiod. Yep. Probably thats better. Then we can also use that as a signal of intended publish to crates.io. Will drop from this series and send again once all current Rust patches landed. - Erik
diff --git a/bindings/rust/libgpiod/Cargo.toml b/bindings/rust/libgpiod/Cargo.toml index 518e5e5..3be4aa0 100644 --- a/bindings/rust/libgpiod/Cargo.toml +++ b/bindings/rust/libgpiod/Cargo.toml @@ -4,7 +4,7 @@ [package] name = "libgpiod" -version = "0.1.0" +version = "0.2.0" authors = ["Viresh Kumar <viresh.kumar@linaro.org>"] description = "libgpiod wrappers" repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git"
Since the type changes around ownership of line_info instances are not necessarily transparent to the user, we bump the major for the next release of the crate. Note: I am using the term "major" as defined in the Rust SemVer compatibility guide [1], where the first non-zero digit is considered as "major". [1] https://doc.rust-lang.org/cargo/reference/semver.html Signed-off-by: Erik Schilling <erik.schilling@linaro.org> --- bindings/rust/libgpiod/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)