| Message ID | 20231005104905.120544-2-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Accepted |
| Commit | a60577cef7de982166baa132a8423f413b617b63 |
| Headers | show |
| Series | MediaTek MDP3: use devicetree to retrieve SCP | expand |
On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote: > The MDP3 RDMA needs to communicate with the SCP remote processor: allow > specifying a phandle to a SCP core. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > > v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed > the description (so, the patch actually changed a bit). I dunno, you made it more informative so you could probably have kept mine at least. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index 7032c7e15039..59dcea797b71 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -45,6 +45,14 @@ properties: > include/dt-bindings/gce/<chip>-gce.h of each chips. > $ref: /schemas/types.yaml#/definitions/uint32-array > > + mediatek,scp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the System Control Processor (SCP) used for initializing > + and stopping the MDP3, for sending frame data locations to the MDP3's > + VPU and to install Inter-Processor Interrupt handlers to control > + processing states. > + > power-domains: > maxItems: 1 > > -- > 2.42.0 >
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> On 05/10/2023 12:49, AngeloGioacchino Del Regno wrote: > The MDP3 RDMA needs to communicate with the SCP remote processor: allow > specifying a phandle to a SCP core.
Il 06/10/23 01:36, Conor Dooley ha scritto: > On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote: >> The MDP3 RDMA needs to communicate with the SCP remote processor: allow >> specifying a phandle to a SCP core. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> >> v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed >> the description (so, the patch actually changed a bit). > > I dunno, you made it more informative so you could probably have kept > mine at least. > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > I just wanted to be cautious with keeping Reviewed-by tags. Sometimes it's better to drop than unfairly keeping, I'm sure that you understand my point here. Btw, thank you! Cheers, Angelo > Thanks, > Conor. > >> >> .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml >> index 7032c7e15039..59dcea797b71 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml >> @@ -45,6 +45,14 @@ properties: >> include/dt-bindings/gce/<chip>-gce.h of each chips. >> $ref: /schemas/types.yaml#/definitions/uint32-array >> >> + mediatek,scp: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the System Control Processor (SCP) used for initializing >> + and stopping the MDP3, for sending frame data locations to the MDP3's >> + VPU and to install Inter-Processor Interrupt handlers to control >> + processing states. >> + >> power-domains: >> maxItems: 1 >> >> -- >> 2.42.0 >> >> >> _______________________________________________ >> Kernel mailing list -- kernel@mailman.collabora.com >> To unsubscribe send an email to kernel-leave@mailman.collabora.com
On Wed, Oct 11, 2023 at 01:44:24PM +0200, AngeloGioacchino Del Regno wrote: > Il 06/10/23 01:36, Conor Dooley ha scritto: > > On Thu, Oct 05, 2023 at 12:49:04PM +0200, AngeloGioacchino Del Regno wrote: > > > The MDP3 RDMA needs to communicate with the SCP remote processor: allow > > > specifying a phandle to a SCP core. > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > --- > > > > > > v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed > > > the description (so, the patch actually changed a bit). > > > > I dunno, you made it more informative so you could probably have kept > > mine at least. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > I just wanted to be cautious with keeping Reviewed-by tags. > > Sometimes it's better to drop than unfairly keeping, I'm sure that you > understand my point here. Oh aye, I do... And you did call out having dropped the tag, so I appreciate that too. > Btw, thank you! nw chief
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index 7032c7e15039..59dcea797b71 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -45,6 +45,14 @@ properties: include/dt-bindings/gce/<chip>-gce.h of each chips. $ref: /schemas/types.yaml#/definitions/uint32-array + mediatek,scp: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the System Control Processor (SCP) used for initializing + and stopping the MDP3, for sending frame data locations to the MDP3's + VPU and to install Inter-Processor Interrupt handlers to control + processing states. + power-domains: maxItems: 1
The MDP3 RDMA needs to communicate with the SCP remote processor: allow specifying a phandle to a SCP core. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- v2: I've dropped Conor and Chen-Yu's Reviewed-by tags because I have changed the description (so, the patch actually changed a bit). .../devicetree/bindings/media/mediatek,mdp3-rdma.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)