diff mbox series

[2/5] i2c: qcom-cci: Add sc8280xp compatible

Message ID 20231006120159.3413789-3-bryan.odonoghue@linaro.org
State New
Headers show
Series Add sc8280xp CCI and CAMSS core dtsi | expand

Commit Message

Bryan O'Donoghue Oct. 6, 2023, 12:01 p.m. UTC
Add sc8280xp compatible with cci_v2_data parameters.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/i2c/busses/i2c-qcom-cci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio Oct. 6, 2023, 11:21 p.m. UTC | #1
On 6.10.2023 14:01, Bryan O'Donoghue wrote:
> Add sc8280xp compatible with cci_v2_data parameters.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Drop this patch, it adds nothing useful

Konrad
Andi Shyti Oct. 8, 2023, 9:28 p.m. UTC | #2
Hi Konrad,

> > Add sc8280xp compatible with cci_v2_data parameters.
> > 
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > ---
> Drop this patch, it adds nothing useful

what about the rest of the series?

Could you please be a bit more explicative?

Thanks,
Andi
Bryan O'Donoghue Oct. 8, 2023, 10:13 p.m. UTC | #3
On 08/10/2023 22:28, Andi Shyti wrote:
> Hi Konrad,
> 
>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> ---
>> Drop this patch, it adds nothing useful
> 
> what about the rest of the series?
> 
> Could you please be a bit more explicative?
> 
> Thanks,
> Andi

I think he means I can use the sm8250 or sm8450 compat string, which is 
true.

---
bod
Bryan O'Donoghue Oct. 8, 2023, 10:26 p.m. UTC | #4
On 08/10/2023 23:13, Bryan O'Donoghue wrote:
> On 08/10/2023 22:28, Andi Shyti wrote:
>> Hi Konrad,
>>
>>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>>
>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>>> ---
>>> Drop this patch, it adds nothing useful
>>
>> what about the rest of the series?
>>
>> Could you please be a bit more explicative?
>>
>> Thanks,
>> Andi
> 
> I think he means I can use the sm8250 or sm8450 compat string, which is 
> true.
> 
> ---
> bod

Tested, compat sm8250 works fine.

---
bod
Konrad Dybcio Oct. 9, 2023, 10:16 a.m. UTC | #5
On 8.10.2023 23:28, Andi Shyti wrote:
> Hi Konrad,
> 
>>> Add sc8280xp compatible with cci_v2_data parameters.
>>>
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> ---
>> Drop this patch, it adds nothing useful
> 
> what about the rest of the series?
> 
> Could you please be a bit more explicative?
This patch introduces a new compatible in the driver that does
exactly nothing, as the bindings require the use of
"qcom,sc8280xp-cci" with a fallback of "qcom,msm8996-cci". The
latter one already has a match table entry.

Konrad
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 414882c57d7f..677e4bc6e2c5 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -819,6 +819,7 @@  static const struct of_device_id cci_dt_match[] = {
 	{ .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
 	{ .compatible = "qcom,sdm845-cci", .data = &cci_v2_data},
 	{ .compatible = "qcom,sm8250-cci", .data = &cci_v2_data},
+	{ .compatible = "qcom,sc8280xp-cci", .data = &cci_v2_data},
 	{ .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},
 	{}
 };