diff mbox series

[libgpiod] bindings: python: replace PyModule_AddObjectRef() with PyModule_AddObjectRef()

Message ID 20231009190729.38675-1-brgl@bgdev.pl
State New
Headers show
Series [libgpiod] bindings: python: replace PyModule_AddObjectRef() with PyModule_AddObjectRef() | expand

Commit Message

Bartosz Golaszewski Oct. 9, 2023, 7:07 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

PyModule_AddObjectRef() was added in cpython v3.10 while libgpiod claims
to depend on python v3.9. Replace it with an older variant that steals the
reference to the added object on success.

Reported-by: Phil Howard <phil@gadgetoid.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 bindings/python/gpiod/ext/module.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/bindings/python/gpiod/ext/module.c b/bindings/python/gpiod/ext/module.c
index 25c252a..b456190 100644
--- a/bindings/python/gpiod/ext/module.c
+++ b/bindings/python/gpiod/ext/module.c
@@ -178,9 +178,9 @@  PyMODINIT_FUNC PyInit__ext(void)
 		return NULL;
 	}
 
-	ret = PyModule_AddObjectRef(module, "__all__", all);
-	Py_DECREF(all);
+	ret = PyModule_AddObject(module, "__all__", all);
 	if (ret) {
+		Py_DECREF(all);
 		Py_DECREF(module);
 		return NULL;
 	}