diff mbox series

[3/3] hw/pci-host/sh_pcic: Replace magic value by proper definition

Message ID 20231012041237.22281-4-philmd@linaro.org
State Superseded
Headers show
Series hw/pci-host/sh_pcic: Style cleanup | expand

Commit Message

Philippe Mathieu-Daudé Oct. 12, 2023, 4:12 a.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/pci-host/sh_pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yoshinori Sato Oct. 14, 2023, 3:10 p.m. UTC | #1 
On Thu, 12 Oct 2023 13:12:37 +0900,
Philippe Mathieu-Daudé wrote:
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
>  hw/pci-host/sh_pci.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci-host/sh_pci.c b/hw/pci-host/sh_pci.c
> index 580e273d96..4edebced5e 100644
> --- a/hw/pci-host/sh_pci.c
> +++ b/hw/pci-host/sh_pci.c
> @@ -40,7 +40,7 @@ struct SHPCIState {
>      PCIHostState parent_obj;
>  
>      PCIDevice *dev;
> -    qemu_irq irq[4];
> +    qemu_irq irq[PCI_NUM_PINS];
>      MemoryRegion memconfig_p4;
>      MemoryRegion memconfig_a7;
>      MemoryRegion isa;
> @@ -131,7 +131,8 @@ static void sh_pcic_host_realize(DeviceState *dev, Error **errp)
>                                       s->irq,
>                                       get_system_memory(),
>                                       get_system_io(),
> -                                     PCI_DEVFN(0, 0), 4, TYPE_PCI_BUS);
> +                                     PCI_DEVFN(0, 0), PCI_NUM_PINS,
> +                                     TYPE_PCI_BUS);
>      memory_region_init_io(&s->memconfig_p4, OBJECT(s), &sh_pci_reg_ops, s,
>                            "sh_pci", 0x224);
>      memory_region_init_alias(&s->memconfig_a7, OBJECT(s), "sh_pci.2",
> -- 
> 2.41.0
>
diff mbox series

Patch

diff --git a/hw/pci-host/sh_pci.c b/hw/pci-host/sh_pci.c
index 580e273d96..4edebced5e 100644
--- a/hw/pci-host/sh_pci.c
+++ b/hw/pci-host/sh_pci.c
@@ -40,7 +40,7 @@  struct SHPCIState {
     PCIHostState parent_obj;
 
     PCIDevice *dev;
-    qemu_irq irq[4];
+    qemu_irq irq[PCI_NUM_PINS];
     MemoryRegion memconfig_p4;
     MemoryRegion memconfig_a7;
     MemoryRegion isa;
@@ -131,7 +131,8 @@  static void sh_pcic_host_realize(DeviceState *dev, Error **errp)
                                      s->irq,
                                      get_system_memory(),
                                      get_system_io(),
-                                     PCI_DEVFN(0, 0), 4, TYPE_PCI_BUS);
+                                     PCI_DEVFN(0, 0), PCI_NUM_PINS,
+                                     TYPE_PCI_BUS);
     memory_region_init_io(&s->memconfig_p4, OBJECT(s), &sh_pci_reg_ops, s,
                           "sh_pci", 0x224);
     memory_region_init_alias(&s->memconfig_a7, OBJECT(s), "sh_pci.2",