| Message ID | 20231013015951.16812-1-edson.drosdeck@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: pci: Missing a blank line after declarations | expand |
On Fri, 13 Oct 2023 03:59:51 +0200, Edson Juliano Drosdeck wrote: > > Warning found by checkpatch.pl script. Adding blank line after declarations. > > Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com> Thanks for the patch. But in general we take such a white-space cleanup patch only when it's associated with another real code changes. Takashi > --- > sound/pci/lola/lola_proc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/lola/lola_proc.c b/sound/pci/lola/lola_proc.c > index a166672e22cb..1ee5997da3c9 100644 > --- a/sound/pci/lola/lola_proc.c > +++ b/sound/pci/lola/lola_proc.c > @@ -137,6 +137,7 @@ static void lola_proc_codec_rw_write(struct snd_info_entry *entry, > struct lola *chip = entry->private_data; > char line[64]; > unsigned int id, verb, data, extdata; > + > while (!snd_info_get_line(buffer, line, sizeof(line))) { > if (sscanf(line, "%u %u %u %u", &id, &verb, &data, &extdata) != 4) > continue; > @@ -150,6 +151,7 @@ static void lola_proc_codec_rw_read(struct snd_info_entry *entry, > struct snd_info_buffer *buffer) > { > struct lola *chip = entry->private_data; > + > snd_iprintf(buffer, "0x%x 0x%x\n", chip->debug_res, chip->debug_res_ex); > } > > -- > 2.39.2 >
diff --git a/sound/pci/lola/lola_proc.c b/sound/pci/lola/lola_proc.c index a166672e22cb..1ee5997da3c9 100644 --- a/sound/pci/lola/lola_proc.c +++ b/sound/pci/lola/lola_proc.c @@ -137,6 +137,7 @@ static void lola_proc_codec_rw_write(struct snd_info_entry *entry, struct lola *chip = entry->private_data; char line[64]; unsigned int id, verb, data, extdata; + while (!snd_info_get_line(buffer, line, sizeof(line))) { if (sscanf(line, "%u %u %u %u", &id, &verb, &data, &extdata) != 4) continue; @@ -150,6 +151,7 @@ static void lola_proc_codec_rw_read(struct snd_info_entry *entry, struct snd_info_buffer *buffer) { struct lola *chip = entry->private_data; + snd_iprintf(buffer, "0x%x 0x%x\n", chip->debug_res, chip->debug_res_ex); }
Warning found by checkpatch.pl script. Adding blank line after declarations. Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com> --- sound/pci/lola/lola_proc.c | 2 ++ 1 file changed, 2 insertions(+)