| Message ID | 20231017131851.8299-2-quic_kriskura@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,1/8] dt-bindings: usb: qcom,dwc3: Add bindings to enable runtime | expand |
On 17/10/2023 14:18, Krishna Kurapati wrote: > Add enable-rt binding to let the device register vendor hooks to > core and facilitate runtime suspend and resume. Hi Krishna, From reading through these patches, it's not clear to me why this behaviour should be conditional on a new devicetree property. Are there some platforms where this behaviour would be undesirable? And if so then would it be possible to determine this based on the QSCRATCH registers? > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index cb50261c6a36..788d9c510abc 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -151,6 +151,11 @@ properties: > HS/FS/LS modes are supported. > type: boolean > > + qcom,enable-rt: > + description: > + If present, register vendor hooks to facilitate runtime suspend/resume > + type: boolean A Krzysztof pointed out, properties should define the hardware behaviour, not tot the implementation details. For this case the hardware isn't wired up to vbus, so maybe something like "qcom,no-vbus"? > + > wakeup-source: true > > # Required child node:
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index cb50261c6a36..788d9c510abc 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -151,6 +151,11 @@ properties: HS/FS/LS modes are supported. type: boolean + qcom,enable-rt: + description: + If present, register vendor hooks to facilitate runtime suspend/resume + type: boolean + wakeup-source: true # Required child node:
Add enable-rt binding to let the device register vendor hooks to core and facilitate runtime suspend and resume. Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)