diff mbox

[2/2] device-tree: nexus7: Add IMEM syscon and reboot reason support

Message ID 1470695643-32169-2-git-send-email-john.stultz@linaro.org
State New
Headers show

Commit Message

John Stultz Aug. 8, 2016, 10:34 p.m. UTC
This patch add the IMEM syscon memory region to the DT,
as well as addds support for the magic reboot reason
values that are written to the address for each mode.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Andy Gross <agross@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: John Stultz <john.stultz@linaro.org>

---
 arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

-- 
1.9.1

Comments

John Stultz Aug. 10, 2016, 5:04 a.m. UTC | #1
On Tue, Aug 9, 2016 at 9:28 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Mon 08 Aug 15:34 PDT 2016, John Stultz wrote:

>

>> This patch add the IMEM syscon memory region to the DT,

>> as well as addds support for the magic reboot reason

>> values that are written to the address for each mode.

>>

>

> This looks good, double checked the addresses and magics. But I think

> you should move the entire thing to qcom-apq8064.dtsi, as this is common

> to the base platform.


Interesting, so do all 8064's use the same bootloader?

> And I would prefer if you updated the subject prefix...

>

> With the move and subject update:

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


thanks!
-john
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
index 7b05f07..ff856c3 100644
--- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
@@ -272,5 +272,19 @@ 
 				vqmmc-supply = <&pm8921_s4>;
 			};
 		};
+
+		imem@2a03f000 {
+			compatible = "syscon", "simple-mfd";
+			reg = <0x2a03f000 0x1000>;
+
+			reboot-mode {
+				compatible = "syscon-reboot-mode";
+				offset = <0x65c>;
+
+				mode-normal	= <0x77665501>;
+				mode-bootloader	= <0x77665500>;
+				mode-recovery	= <0x77665502>;
+			};
+		};
 	};
 };