From patchwork Tue Aug 9 01:23:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 73501 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp239769qga; Mon, 8 Aug 2016 18:23:40 -0700 (PDT) X-Received: by 10.66.10.168 with SMTP id j8mr63787670pab.3.1470705819910; Mon, 08 Aug 2016 18:23:39 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j71si39744375pfa.161.2016.08.08.18.23.39; Mon, 08 Aug 2016 18:23:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752363AbcHIBXh (ORCPT + 27 others); Mon, 8 Aug 2016 21:23:37 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35279 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbcHIBXe (ORCPT ); Mon, 8 Aug 2016 21:23:34 -0400 Received: by mail-pa0-f50.google.com with SMTP id iw10so118711392pac.2 for ; Mon, 08 Aug 2016 18:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hO2vB8u2DLCcXtwntvKPAOsr8P/9XE3UqNx/LfNLbf0=; b=AXKwIM0FKU0PEXATGHcPpvtNZIpbpB1+5Kd6bq4efLYf84IRAjI3WJD2lSZRRW+cYe iJmFMLOCoAwWrGQK5PxFl96FtfsL8orzfA1h+TlboigWA4/IklmB9xYCVdk8o1z7MO8E b37O7v7DV1a+wB2djwHgiJlLGS75OLfKv8IUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hO2vB8u2DLCcXtwntvKPAOsr8P/9XE3UqNx/LfNLbf0=; b=F6GmMu3yey5QI79j8zcWIErTOk35BN185qNYSse1zj/WMTxZFm3xh3UYomdUm/KKed kwfbMc+MgtAUoPjliQGRpwMljL0y8LpPJBS1bWiWEBuLHiNu904tu0pHBl7yA/7xvxit bAg9DJG5chZX0IO7+7LRbDgjNg+bLtxJNMpD6lFLqbnVjf3xIg22w44mKAE8ARiQHtPF 6PJaFG6ALpB6Mt8vET+l6rxpfv/7ZIsmrSqbpuhPeSkBSELUhkhqby3kTa7yFA5jeeV8 vw13xXhT4swfMZsJldevmLBoAsj9nbLYn7YSd2K5FfB8jCbWbezC1HofJEIYUf9NldZs TyMA== X-Gm-Message-State: AEkoouvMzaXv2ylCxtpH9nOQAzlj12ETtCIS3BHbP3+N14tG4EbuImSLmO3cT8FcnH53qVqC X-Received: by 10.66.135.40 with SMTP id pp8mr168999382pab.113.1470705812383; Mon, 08 Aug 2016 18:23:32 -0700 (PDT) Received: from leoy-linaro (61-216-91-114.HINET-IP.hinet.net. [61.216.91.114]) by smtp.gmail.com with ESMTPSA id m24sm50912268pfi.34.2016.08.08.18.23.07 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 08 Aug 2016 18:23:31 -0700 (PDT) Date: Tue, 9 Aug 2016 09:23:03 +0800 From: Leo Yan To: Daniel Thompson Cc: Amit Kucheria , Michael Turquette , Stephen Boyd , Jiancheng Xue , Philipp Zabel , Rob Herring , linux-clk@vger.kernel.org, LKML , Dietmar Eggemann , Guodong Xu Subject: Re: [PATCH] clk: Hi6220: enable stub clock driver for ARCH_HISI Message-ID: <20160809012303.GA19812@leoy-linaro> References: <1470627463-20570-1-git-send-email-leo.yan@linaro.org> <20160808064241.GA30622@leoy-linaro> <5d98a054-c057-81eb-9ee7-789353a093e5@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 09:36:32PM +0100, Daniel Thompson wrote: [...] > >My earlier patch focused on enabling the stub driver in the case the > >thermal driver was enabled (and subsequently turning on HISI_THERMAL > >in defconfig). The EAS profiling usecase to prevent thermal-throttling > >from kicking in is a bad default to have in the kernel, IMO - it can > >be easily achieved by just changing the thermal thresholds. > > > >Something like the following, with HISI_THERMAL added to defconfig > >would give a "stable" kernel on Hikey. > > > >diff --git i/drivers/thermal/Kconfig w/drivers/thermal/Kconfig > >index 2d702ca..77597a5 100644 > >--- i/drivers/thermal/Kconfig > >+++ w/drivers/thermal/Kconfig > >@@ -177,8 +177,11 @@ config THERMAL_EMULATION > > > > config HISI_THERMAL > > tristate "Hisilicon thermal driver" > >- depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST > >+ depends on (ARCH_HISI && OF) || COMPILE_TEST > > depends on HAS_IOMEM > >+ select CPU_THERMAL > >+ select CPUFREQ_DT > >+ select STUB_CLK_HI6220 > > I'm actually a little uncomfortable having a thermal sensor dictate > what cooling devices are used to react to its temperature reading. > The link between sensors and cooling devices comes from DT. > > However I admit there are other platforms (IMX and DB8500) that > accept the same build time diktat from their thermal sensors. For thermal enabling on Hikey with CPU cooling device, how about below change? I checked arch/arm/configs/multi_v7_defconfig, both CONFIG_CPUFREQ_DT and CONFIG_CPU_THERMAL have been enabled in it. These two drivers are quite common and used by many ARM platforms. diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 0555b7c..f65336f 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -78,6 +78,7 @@ CONFIG_COMPAT=y CONFIG_CPU_IDLE=y CONFIG_ARM_CPUIDLE=y CONFIG_CPU_FREQ=y +CONFIG_CPUFREQ_DT=y CONFIG_ARM_BIG_LITTLE_CPUFREQ=y CONFIG_ARM_SCPI_CPUFREQ=y CONFIG_NET=y @@ -217,6 +218,7 @@ CONFIG_SENSORS_INA2XX=m CONFIG_SENSORS_ARM_SCPI=y CONFIG_THERMAL=y CONFIG_THERMAL_EMULATION=y +CONFIG_CPU_THERMAL=y CONFIG_EXYNOS_THERMAL=y CONFIG_WATCHDOG=y CONFIG_RENESAS_WDT=y diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 2d702ca..91ebab3 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -177,8 +177,10 @@ config THERMAL_EMULATION config HISI_THERMAL tristate "Hisilicon thermal driver" - depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST + depends on ARCH_HISI || COMPILE_TEST depends on HAS_IOMEM + depends on OF + default y help Enable this to plug hisilicon's thermal sensor driver into the Linux thermal framework. cpufreq is used as the cooling device to throttle