diff mbox series

[BlueZ,v2,1/1] gobex/gobex.c : Increase default obex timeout from 10 sec to 500 sec

Message ID 20231020093716.9654-2-purendra.singh@nxp.com
State New
Headers show
Series Increase default obex timeout: 10 sec to 500 sec | expand

Commit Message

Purendra Singh Oct. 20, 2023, 9:37 a.m. UTC 
This issue is observed when multiple profiles are active from
multiple connected devices: A2DP + HID + OBex File transfer

File received status of some reference devices is delayed,
that causes timeout and file transfer status error (Variation
of timeout is between ~100 seconds to ~450 seconds).

We tested with Motorola Edge, Samsung M33, OnePlus 6T.

Experimentaly we increased the timeout and at 500 seconds no issue was
observed.
---
 gobex/gobex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Purendra Singh Oct. 31, 2023, 12:10 p.m. UTC | #1 
Hello Luiz and Paul,

> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Sent: Friday, October 20, 2023 11:19 PM
> To: Paul Menzel <pmenzel@molgen.mpg.de>
> Cc: Purendra Singh <purendra.singh@nxp.com>; linux-
> bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>;
> Nitin Jadhav <nitin.jadhav@nxp.com>
> Subject: [EXT] Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default
> obex timeout from 10 sec to 500 sec
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hi,
> 
> On Fri, Oct 20, 2023 at 2:44 AM Paul Menzel <pmenzel@molgen.mpg.de>
> wrote:
> >
> > Dear Purendra,
> >
> >
> > Thank you for sending version 2. (No space is necessary in the prefix
> > before the colon.)
> >
> >
> > Am 20.10.23 um 11:37 schrieb Purendra Singh:
> > > This issue is observed when multiple profiles are active from
> > > multiple connected devices: A2DP + HID + OBex File transfer
> > >
> > > File received status of some reference devices is delayed, that
> > > causes timeout and file transfer status error (Variation of timeout
> > > is between ~100 seconds to ~450 seconds).
> > >
> > > We tested with Motorola Edge, Samsung M33, OnePlus 6T.
> > >
> > > Experimentaly we increased the timeout and at 500 seconds no issue
> > > was
> >
> > Experimentally
> >
> > > observed.
> >
> > Oh, it’s really seconds. Isn’t greater than 8 minute timeout *not*
> > very user friendly?
> 
> Yeah, something like that would probably cause the user to  assume the
> operation didn't work.

This is the maximum timeout we have set based on experimenting
different reference devices mentioned in earlier comment.
This will only come into picture if the reference devices slow in 
responding the file received status.
> 
> > > ---
> > >   gobex/gobex.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/gobex/gobex.c b/gobex/gobex.c index
> > > e9b89cead..f0e1c2c83 100644
> > > --- a/gobex/gobex.c
> > > +++ b/gobex/gobex.c
> > > @@ -22,7 +22,7 @@
> > >   #define G_OBEX_MINIMUM_MTU  255
> > >   #define G_OBEX_MAXIMUM_MTU  65535
> > >
> > > -#define G_OBEX_DEFAULT_TIMEOUT       10
> > > +#define G_OBEX_DEFAULT_TIMEOUT       500
> > >   #define G_OBEX_ABORT_TIMEOUT        5
> > >
> > >   #define G_OBEX_OP_NONE              0xff
> >
> >
> > Kind regards,
> >
> > Paul
> 
> 
> 
> --
> Luiz Augusto von Dentz

Thanks 
Purendra
diff mbox series

Patch

diff --git a/gobex/gobex.c b/gobex/gobex.c
index e9b89cead..f0e1c2c83 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -22,7 +22,7 @@ 
 #define G_OBEX_MINIMUM_MTU	255
 #define G_OBEX_MAXIMUM_MTU	65535
 
-#define G_OBEX_DEFAULT_TIMEOUT	10
+#define G_OBEX_DEFAULT_TIMEOUT	500
 #define G_OBEX_ABORT_TIMEOUT	5
 
 #define G_OBEX_OP_NONE		0xff