diff mbox series

[RFC,12/13] lib: uuid: move CONFIG_RANDOM_UUID

Message ID 20231026053052.622453-13-takahiro.akashi@linaro.org
State Superseded
Headers show
Series cmd: bootefi: refactor the code for bootmgr | expand

Commit Message

AKASHI Takahiro Oct. 26, 2023, 5:30 a.m. UTC
This option is independent from any commands and should be managed
under lib. For instance, drivers/block/rkmtd.c is a user.

It would be better to remove this configuration.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 cmd/Kconfig | 7 -------
 lib/Kconfig | 7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Tom Rini Oct. 26, 2023, 12:47 p.m. UTC | #1
On Thu, Oct 26, 2023 at 02:30:51PM +0900, AKASHI Takahiro wrote:

> This option is independent from any commands and should be managed
> under lib. For instance, drivers/block/rkmtd.c is a user.
> 
> It would be better to remove this configuration.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

Reviewed-by: Tom Rini <trini@konsulko.com>
Ilias Apalodimas Oct. 27, 2023, 12:24 p.m. UTC | #2
On Thu, 26 Oct 2023 at 08:31, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
>
> This option is independent from any commands and should be managed
> under lib. For instance, drivers/block/rkmtd.c is a user.
>
> It would be better to remove this configuration.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  cmd/Kconfig | 7 -------
>  lib/Kconfig | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 3a8483f7d042..c42745d06b39 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1143,13 +1143,6 @@ config CMD_GPT
>           Enable the 'gpt' command to ready and write GPT style partition
>           tables.
>
> -config RANDOM_UUID
> -       bool "GPT Random UUID generation"
> -       select LIB_UUID
> -       help
> -         Enable the generation of partitions with random UUIDs if none
> -         are provided.
> -
>  config CMD_GPT_RENAME
>         bool "GPT partition renaming commands"
>         depends on CMD_GPT
> diff --git a/lib/Kconfig b/lib/Kconfig
> index f6ca559897e7..b6d580c30615 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -74,6 +74,13 @@ config HAVE_PRIVATE_LIBGCC
>  config LIB_UUID
>         bool
>
> +config RANDOM_UUID
> +       bool "GPT Random UUID generation"
> +       select LIB_UUID
> +       help
> +         Enable the generation of partitions with random UUIDs if none
> +         are provided.
> +
>  config SPL_LIB_UUID
>         depends on SPL
>         bool
> --
> 2.34.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 3a8483f7d042..c42745d06b39 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1143,13 +1143,6 @@  config CMD_GPT
 	  Enable the 'gpt' command to ready and write GPT style partition
 	  tables.
 
-config RANDOM_UUID
-	bool "GPT Random UUID generation"
-	select LIB_UUID
-	help
-	  Enable the generation of partitions with random UUIDs if none
-	  are provided.
-
 config CMD_GPT_RENAME
 	bool "GPT partition renaming commands"
 	depends on CMD_GPT
diff --git a/lib/Kconfig b/lib/Kconfig
index f6ca559897e7..b6d580c30615 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -74,6 +74,13 @@  config HAVE_PRIVATE_LIBGCC
 config LIB_UUID
 	bool
 
+config RANDOM_UUID
+	bool "GPT Random UUID generation"
+	select LIB_UUID
+	help
+	  Enable the generation of partitions with random UUIDs if none
+	  are provided.
+
 config SPL_LIB_UUID
 	depends on SPL
 	bool