| Message ID | TYAP286MB0315FE921FF113BF76F7B700BCA0A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] dt-bindings: leds: sort LED color definitions by alphabet | expand |
On Tue, Oct 31, 2023 at 6:16 AM Shiji Yang <yangshiji66@outlook.com> wrote: > > Sorting LEDs by alphabet can help developers quickly find the colors > they want. Infrared and multicolor LEDs are special so they should > be left at the end of the list. This is an ABI. You cannot renumber them. Use get_maintainer.pl when sending your patches. You missed the DT list. > > Signed-off-by: Shiji Yang <yangshiji66@outlook.com> > --- > include/dt-bindings/leds/common.h | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-)
On 31/10/2023 12:15, Shiji Yang wrote: > Sorting LEDs by alphabet can help developers quickly find the colors > they want. Infrared and multicolor LEDs are special so they should > be left at the end of the list. > > Signed-off-by: Shiji Yang <yangshiji66@outlook.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 9a0d33d02..33c9dd873 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -22,22 +22,23 @@ #define LEDS_BOOST_FIXED 2 /* Standard LED colors */ -#define LED_COLOR_ID_WHITE 0 -#define LED_COLOR_ID_RED 1 -#define LED_COLOR_ID_GREEN 2 -#define LED_COLOR_ID_BLUE 3 -#define LED_COLOR_ID_AMBER 4 -#define LED_COLOR_ID_VIOLET 5 -#define LED_COLOR_ID_YELLOW 6 -#define LED_COLOR_ID_IR 7 -#define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */ -#define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color, +#define LED_COLOR_ID_AMBER 0 +#define LED_COLOR_ID_BLUE 1 +#define LED_COLOR_ID_CYAN 2 +#define LED_COLOR_ID_GREEN 3 +#define LED_COLOR_ID_LIME 4 +#define LED_COLOR_ID_ORANGE 5 +#define LED_COLOR_ID_PINK 6 +#define LED_COLOR_ID_PURPLE 7 +#define LED_COLOR_ID_RED 8 +#define LED_COLOR_ID_VIOLET 9 +#define LED_COLOR_ID_WHITE 10 +#define LED_COLOR_ID_YELLOW 11 +/* These LEDs are special */ +#define LED_COLOR_ID_IR 12 +#define LED_COLOR_ID_MULTI 13 /* For multicolor LEDs */ +#define LED_COLOR_ID_RGB 14 /* For multicolor LEDs that can do arbitrary color, so this would include RGBW and similar */ -#define LED_COLOR_ID_PURPLE 10 -#define LED_COLOR_ID_ORANGE 11 -#define LED_COLOR_ID_PINK 12 -#define LED_COLOR_ID_CYAN 13 -#define LED_COLOR_ID_LIME 14 #define LED_COLOR_ID_MAX 15 /* Standard LED functions */
Sorting LEDs by alphabet can help developers quickly find the colors they want. Infrared and multicolor LEDs are special so they should be left at the end of the list. Signed-off-by: Shiji Yang <yangshiji66@outlook.com> --- include/dt-bindings/leds/common.h | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-)