| Message ID | 20231106-pm8937-v1-8-ec51d9eeec53@riseup.net |
|---|---|
| State | Accepted |
| Commit | d50b5cb1a8f7db8ad2dc6a13f0cabedf7a7e1540 |
| Headers | show |
| Series | Add PM8937 PMIC support | expand |
On 11/6/23 13:08, Dang Huynh wrote: > The PM8917 and PM8937 uses the same SUBTYPE ID. > > The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940 > and APQ variants. > > Signed-off-by: Dang Huynh <danct12@riseup.net> > --- Are they secretly the same thing? Do you know somebody with a PM8917- equipped device to check that theory out? Konrad
On Tuesday, November 7, 2023 9:30:34 PM UTC Konrad Dybcio wrote: > On 11/6/23 13:08, Dang Huynh wrote: > > The PM8917 and PM8937 uses the same SUBTYPE ID. > > > > The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940 > > and APQ variants. > > > > Signed-off-by: Dang Huynh <danct12@riseup.net> > > --- > > Are they secretly the same thing? Do you know somebody with a PM8917- > equipped device to check that theory out? > > Konrad I don't know anyone with a PM8917 device, but I did check with downstream source and all the reference to pm8917 are either not used in any dts or point towards pm8937. Dang
On Tue, Nov 07, 2023 at 10:30:34PM +0100, Konrad Dybcio wrote: > > > On 11/6/23 13:08, Dang Huynh wrote: > > The PM8917 and PM8937 uses the same SUBTYPE ID. > > > > The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940 > > and APQ variants. > > > > Signed-off-by: Dang Huynh <danct12@riseup.net> > > --- > Are they secretly the same thing? Do you know somebody with a PM8917- > equipped device to check that theory out? > PM8917 and PM8937 are not the same. Regards, Bjorn
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index 51e05bec5bfc..37692fc1aefb 100644 --- a/drivers/soc/qcom/socinfo.c +++ b/drivers/soc/qcom/socinfo.c @@ -93,7 +93,7 @@ static const char *const pmic_models[] = { [22] = "PM8821", [23] = "PM8038", [24] = "PM8005/PM8922", - [25] = "PM8917", + [25] = "PM8917/PM8937", [26] = "PM660L", [27] = "PM660", [30] = "PM8150",
The PM8917 and PM8937 uses the same SUBTYPE ID. The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940 and APQ variants. Signed-off-by: Dang Huynh <danct12@riseup.net> --- drivers/soc/qcom/socinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)