| Message ID | 1471531928-16150-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 84bc9a4cdc3569f79d894f4644a4e0051155be24 |
| Headers | show |
On 18 August 2016 at 10:52, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > socket mmap is not performance target for pktio. Improving > performance for it needs more profiling and understanding > it's work. Remove this todo because there is no plan to work > on performance for socket mmap. > https://bugs.linaro.org/show_bug.cgi?id=2409 > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > --- > platform/linux-generic/pktio/socket_mmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/platform/linux-generic/pktio/socket_mmap.c > b/platform/linux-generic/pktio/socket_mmap.c > index 8b24c99..9655668 100644 > --- a/platform/linux-generic/pktio/socket_mmap.c > +++ b/platform/linux-generic/pktio/socket_mmap.c > @@ -345,7 +345,6 @@ static inline unsigned pkt_mmap_v2_tx(int sock, struct > ring *ring, > > static void mmap_fill_ring(struct ring *ring, odp_pool_t pool_hdl, int > fanout) > { > - /*@todo add Huge Pages support*/ > int pz = getpagesize(); > uint32_t pool_id; > pool_entry_t *pool_entry; > -- > 2.7.1.250.gff4ea60 > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
Merged. On 08/18/16 18:01, Mike Holmes wrote: > > > On 18 August 2016 at 10:52, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > socket mmap is not performance target for pktio. Improving > performance for it needs more profiling and understanding > it's work. Remove this todo because there is no plan to work > on performance for socket mmap. > https://bugs.linaro.org/show_bug.cgi?id=2409 > <https://bugs.linaro.org/show_bug.cgi?id=2409> > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > > > Reviewed-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > > --- > platform/linux-generic/pktio/socket_mmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/platform/linux-generic/pktio/socket_mmap.c > b/platform/linux-generic/pktio/socket_mmap.c > index 8b24c99..9655668 100644 > --- a/platform/linux-generic/pktio/socket_mmap.c > +++ b/platform/linux-generic/pktio/socket_mmap.c > @@ -345,7 +345,6 @@ static inline unsigned pkt_mmap_v2_tx(int > sock, struct ring *ring, > > static void mmap_fill_ring(struct ring *ring, odp_pool_t > pool_hdl, int fanout) > { > - /*@todo add Huge Pages support*/ > int pz = getpagesize(); > uint32_t pool_id; > pool_entry_t *pool_entry; > -- > 2.7.1.250.gff4ea60 > > > > > -- > Mike Holmes > Program Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" >
diff --git a/platform/linux-generic/pktio/socket_mmap.c b/platform/linux-generic/pktio/socket_mmap.c index 8b24c99..9655668 100644 --- a/platform/linux-generic/pktio/socket_mmap.c +++ b/platform/linux-generic/pktio/socket_mmap.c @@ -345,7 +345,6 @@ static inline unsigned pkt_mmap_v2_tx(int sock, struct ring *ring, static void mmap_fill_ring(struct ring *ring, odp_pool_t pool_hdl, int fanout) { - /*@todo add Huge Pages support*/ int pz = getpagesize(); uint32_t pool_id; pool_entry_t *pool_entry;
socket mmap is not performance target for pktio. Improving performance for it needs more profiling and understanding it's work. Remove this todo because there is no plan to work on performance for socket mmap. https://bugs.linaro.org/show_bug.cgi?id=2409 Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- platform/linux-generic/pktio/socket_mmap.c | 1 - 1 file changed, 1 deletion(-) -- 2.7.1.250.gff4ea60