| Message ID | 20231111164229.63803-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | fdff2141be44696f5cc69f2f6c20c26b9ac00760 |
| Headers | show |
| Series | [1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs | expand |
On 11.11.2023 17:42, Krzysztof Kozlowski wrote: > Linux handles both versions, but bindings expect GPIO properties to > have 'gpios' suffix instead of 'gpio': > > sc8180x-lenovo-flex-5g.dtb: pci@1c08000: Unevaluated properties are not allowed ('perst-gpio', 'wake-gpio' were unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Sat, 11 Nov 2023 17:42:24 +0100, Krzysztof Kozlowski wrote: > Linux handles both versions, but bindings expect GPIO properties to > have 'gpios' suffix instead of 'gpio': > > sc8180x-lenovo-flex-5g.dtb: pci@1c08000: Unevaluated properties are not allowed ('perst-gpio', 'wake-gpio' were unexpected) > > Applied, thanks! [1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs commit: fdff2141be44696f5cc69f2f6c20c26b9ac00760 [2/6] arm64: dts: qcom: sc8180x-primus: use 'gpios' suffix for PCI GPIOs commit: 9a1bd36aeb31649bc499f87671b76c7d117197e6 [3/6] arm64: dts: qcom: sm8150: use 'gpios' suffix for PCI GPIOs commit: af6f6778d34cb40e60368e288767f674cc0c5f60 [4/6] arm64: dts: qcom: sm6115: align mem timer size cells with bindings commit: f52f11271d90b1361a8364729a63a36b7456bc89 [5/6] arm64: dts: qcom: sm6125: add interrupts to DWC3 USB controller commit: 67e4656f4487b95a39e45884c99235f62ebfaa47 [6/6] arm64: dts: qcom: sm6375-pdx225: add fixed touchscreen AVDD regulator commit: 0d10ac7d2d9420d143ee738abbb06a9201e611b9 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts index 3ea07d094b60..0c22f3efec20 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts @@ -452,8 +452,8 @@ mdss_edp_out: endpoint { }; &pcie3 { - perst-gpio = <&tlmm 178 GPIO_ACTIVE_LOW>; - wake-gpio = <&tlmm 180 GPIO_ACTIVE_HIGH>; + perst-gpios = <&tlmm 178 GPIO_ACTIVE_LOW>; + wake-gpios = <&tlmm 180 GPIO_ACTIVE_HIGH>; pinctrl-0 = <&pcie3_default_state>; pinctrl-names = "default";
Linux handles both versions, but bindings expect GPIO properties to have 'gpios' suffix instead of 'gpio': sc8180x-lenovo-flex-5g.dtb: pci@1c08000: Unevaluated properties are not allowed ('perst-gpio', 'wake-gpio' were unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)