| Message ID | 20231130171940.12391-1-johan+linaro@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: leds: qcom,spmi-flash-led: fix example node name | expand |
On 30/11/2023 18:19, Johan Hovold wrote: > The led controller is a child of an SPMI PMIC, which in turn sits on an > SPMI bus. > > While at it, add some newline separators to improve readability. > > Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller") Nothing to fix here, just an example code. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Dec 01, 2023 at 09:42:02AM +0100, Krzysztof Kozlowski wrote: > On 30/11/2023 18:19, Johan Hovold wrote: > > The led controller is a child of an SPMI PMIC, which in turn sits on an > > SPMI bus. > > > > While at it, add some newline separators to improve readability. > > > > Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller") > > Nothing to fix here, just an example code. I'll just refer to my reply here for completeness: https://lore.kernel.org/all/ZWmn6uicNIqqSwoE@hovoldconsulting.com/ Johan
diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml index a8736fd5a539..1ba607685f5f 100644 --- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml @@ -89,9 +89,11 @@ additionalProperties: false examples: - | #include <dt-bindings/leds/common.h> - spmi { + + pmic { #address-cells = <1>; #size-cells = <0>; + led-controller@ee00 { compatible = "qcom,pm8350c-flash-led", "qcom,spmi-flash-led"; reg = <0xee00>;
The led controller is a child of an SPMI PMIC, which in turn sits on an SPMI bus. While at it, add some newline separators to improve readability. Fixes: 1aeff6216891 ("dt-bindings: leds: Add QCOM flash LED controller") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)