| Message ID | 20231130174254.13180-1-johan+linaro@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: watchdog: qcom,pm8916-wdt: add parent spmi node to example | expand |
On 30/11/2023 18:42, Johan Hovold wrote: > The PM8916 watchdog is part of an SPMI PMIC, which lives on an SPMI bus. > > Add a parent SPMI bus node with an '#address-cells' of 2 and > '#size-cells' of 0 instead of relying on the fact that the default > number of register cells happen to match (i.e. 1 + 1). > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml index 568eb8480fc3..dc6af204e8af 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml @@ -30,22 +30,27 @@ examples: #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/spmi/spmi.h> - pmic@0 { - compatible = "qcom,pm8916", "qcom,spmi-pmic"; - reg = <0x0 SPMI_USID>; - #address-cells = <1>; + spmi { + #address-cells = <2>; #size-cells = <0>; - pon@800 { - compatible = "qcom,pm8916-pon"; - reg = <0x800>; - mode-bootloader = <0x2>; - mode-recovery = <0x1>; - - watchdog { - compatible = "qcom,pm8916-wdt"; - interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; - timeout-sec = <60>; + pmic@0 { + compatible = "qcom,pm8916", "qcom,spmi-pmic"; + reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + pon@800 { + compatible = "qcom,pm8916-pon"; + reg = <0x800>; + mode-bootloader = <0x2>; + mode-recovery = <0x1>; + + watchdog { + compatible = "qcom,pm8916-wdt"; + interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; + timeout-sec = <60>; + }; }; }; };
The PM8916 watchdog is part of an SPMI PMIC, which lives on an SPMI bus. Add a parent SPMI bus node with an '#address-cells' of 2 and '#size-cells' of 0 instead of relying on the fact that the default number of register cells happen to match (i.e. 1 + 1). Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../bindings/watchdog/qcom,pm8916-wdt.yaml | 33 +++++++++++-------- 1 file changed, 19 insertions(+), 14 deletions(-)