mbox

[PULL,0/6] gdbstub, avocado and gitlab updates

Message ID 20231201151228.2610209-1-alex.bennee@linaro.org
State New
Headers show

Pull-request

https://gitlab.com/stsquad/qemu.git tags/pull-more-8.2-fixes-011223-1

Message

Alex Bennée Dec. 1, 2023, 3:12 p.m. UTC
The following changes since commit abf635ddfe3242df907f58967f3c1e6763bbca2d:

  Update version for v8.2.0-rc2 release (2023-11-28 16:31:16 -0500)

are available in the Git repository at:

  https://gitlab.com/stsquad/qemu.git tags/pull-more-8.2-fixes-011223-1

for you to fetch changes up to a7a740cce1ec49568e7ebd8e776279e59e2fb5b6:

  gitlab: add optional job to run flaky avocado tests (2023-12-01 14:12:05 +0000)

----------------------------------------------------------------
Flaky avocado tests, gdbstub and gitlab tweaks

  - gdbstub, properly halt when QEMU is having IO issues
  - convert skipIf(GITLAB_CI) to skipUnless(QEMU_TEST_FLAKY_TESTS)
  - drop mips malta cpio test as assets expire in Debian archive
  - tag sbsa-ref tests as TCG only
  - build the correct microblaze for avocado-system-ubuntu
  - add optional flaky tests job to CI

----------------------------------------------------------------
Alex Bennée (6):
      gdbstub: use a better signal when we halt for IO reasons
      docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
      tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test
      tests/avocado: tag sbsa tests as tcg only
      gitlab: build the correct microblaze target
      gitlab: add optional job to run flaky avocado tests

 docs/devel/testing.rst                   | 32 ++++++++++++++--------
 gdbstub/internals.h                      |  1 +
 gdbstub/system.c                         |  2 +-
 .gitlab-ci.d/buildtest.yml               | 32 +++++++++++++++++++++-
 tests/avocado/boot_linux.py              | 10 +++++--
 tests/avocado/boot_linux_console.py      | 47 +++-----------------------------
 tests/avocado/intel_iommu.py             |  6 ++--
 tests/avocado/linux_initrd.py            |  7 +++--
 tests/avocado/machine_aarch64_sbsaref.py |  4 +++
 tests/avocado/machine_aspeed.py          | 10 +++++--
 tests/avocado/machine_mips_malta.py      | 10 +++++--
 tests/avocado/machine_rx_gdbsim.py       | 10 +++++--
 tests/avocado/machine_s390_ccw_virtio.py |  3 +-
 tests/avocado/replay_kernel.py           |  8 ++++--
 tests/avocado/reverse_debugging.py       | 16 +++++++----
 tests/avocado/smmu.py                    |  6 ++--
 tests/avocado/tuxrun_baselines.py        |  5 ++--
 17 files changed, 125 insertions(+), 84 deletions(-)

Comments

Philippe Mathieu-Daudé Dec. 1, 2023, 4:50 p.m. UTC | #1
Hi Alex,

On 1/12/23 16:12, Alex Bennée wrote:
> The following changes since commit abf635ddfe3242df907f58967f3c1e6763bbca2d:
> 
>    Update version for v8.2.0-rc2 release (2023-11-28 16:31:16 -0500)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/stsquad/qemu.git tags/pull-more-8.2-fixes-011223-1
> 
> for you to fetch changes up to a7a740cce1ec49568e7ebd8e776279e59e2fb5b6:
> 
>    gitlab: add optional job to run flaky avocado tests (2023-12-01 14:12:05 +0000)
> 
> ----------------------------------------------------------------
> Flaky avocado tests, gdbstub and gitlab tweaks
> 
>    - gdbstub, properly halt when QEMU is having IO issues
>    - convert skipIf(GITLAB_CI) to skipUnless(QEMU_TEST_FLAKY_TESTS)
>    - drop mips malta cpio test as assets expire in Debian archive
>    - tag sbsa-ref tests as TCG only
>    - build the correct microblaze for avocado-system-ubuntu
>    - add optional flaky tests job to CI
> 
> ----------------------------------------------------------------
> Alex Bennée (6):
>        gdbstub: use a better signal when we halt for IO reasons
>        docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
>        tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test

This patch has been posted 5h ago and we are still discussing it...
I'm quite surprised you include it in your PR.

>        tests/avocado: tag sbsa tests as tcg only
>        gitlab: build the correct microblaze target
>        gitlab: add optional job to run flaky avocado tests
> 
>   docs/devel/testing.rst                   | 32 ++++++++++++++--------
>   gdbstub/internals.h                      |  1 +
>   gdbstub/system.c                         |  2 +-
>   .gitlab-ci.d/buildtest.yml               | 32 +++++++++++++++++++++-
>   tests/avocado/boot_linux.py              | 10 +++++--
>   tests/avocado/boot_linux_console.py      | 47 +++-----------------------------
>   tests/avocado/intel_iommu.py             |  6 ++--
>   tests/avocado/linux_initrd.py            |  7 +++--
>   tests/avocado/machine_aarch64_sbsaref.py |  4 +++
>   tests/avocado/machine_aspeed.py          | 10 +++++--
>   tests/avocado/machine_mips_malta.py      | 10 +++++--
>   tests/avocado/machine_rx_gdbsim.py       | 10 +++++--
>   tests/avocado/machine_s390_ccw_virtio.py |  3 +-
>   tests/avocado/replay_kernel.py           |  8 ++++--
>   tests/avocado/reverse_debugging.py       | 16 +++++++----
>   tests/avocado/smmu.py                    |  6 ++--
>   tests/avocado/tuxrun_baselines.py        |  5 ++--
>   17 files changed, 125 insertions(+), 84 deletions(-)
> 
>
Philippe Mathieu-Daudé Dec. 1, 2023, 4:52 p.m. UTC | #2
On 1/12/23 17:50, Philippe Mathieu-Daudé wrote:
> Hi Alex,
> 
> On 1/12/23 16:12, Alex Bennée wrote:
>> The following changes since commit 
>> abf635ddfe3242df907f58967f3c1e6763bbca2d:
>>
>>    Update version for v8.2.0-rc2 release (2023-11-28 16:31:16 -0500)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/stsquad/qemu.git tags/pull-more-8.2-fixes-011223-1
>>
>> for you to fetch changes up to a7a740cce1ec49568e7ebd8e776279e59e2fb5b6:
>>
>>    gitlab: add optional job to run flaky avocado tests (2023-12-01 
>> 14:12:05 +0000)
>>
>> ----------------------------------------------------------------
>> Flaky avocado tests, gdbstub and gitlab tweaks
>>
>>    - gdbstub, properly halt when QEMU is having IO issues
>>    - convert skipIf(GITLAB_CI) to skipUnless(QEMU_TEST_FLAKY_TESTS)
>>    - drop mips malta cpio test as assets expire in Debian archive
>>    - tag sbsa-ref tests as TCG only
>>    - build the correct microblaze for avocado-system-ubuntu
>>    - add optional flaky tests job to CI
>>
>> ----------------------------------------------------------------
>> Alex Bennée (6):
>>        gdbstub: use a better signal when we halt for IO reasons
>>        docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
>>        tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test
> 
> This patch has been posted 5h ago and we are still discussing it...
> I'm quite surprised you include it in your PR.

Do you mind re-posting your PR without this patch? I don't
mind to work on it during the WE and merge it let's say
Sunday, if you want it in before this Monday.

Regards,

Phil.
Alex Bennée Dec. 1, 2023, 5:50 p.m. UTC | #3
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 1/12/23 17:50, Philippe Mathieu-Daudé wrote:
>> Hi Alex,
>> On 1/12/23 16:12, Alex Bennée wrote:
>>> The following changes since commit
>>> abf635ddfe3242df907f58967f3c1e6763bbca2d:
>>>
>>>    Update version for v8.2.0-rc2 release (2023-11-28 16:31:16 -0500)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://gitlab.com/stsquad/qemu.git tags/pull-more-8.2-fixes-011223-1
>>>
>>> for you to fetch changes up to a7a740cce1ec49568e7ebd8e776279e59e2fb5b6:
>>>
>>>    gitlab: add optional job to run flaky avocado tests (2023-12-01
>>> 14:12:05 +0000)
>>>
>>> ----------------------------------------------------------------
>>> Flaky avocado tests, gdbstub and gitlab tweaks
>>>
>>>    - gdbstub, properly halt when QEMU is having IO issues
>>>    - convert skipIf(GITLAB_CI) to skipUnless(QEMU_TEST_FLAKY_TESTS)
>>>    - drop mips malta cpio test as assets expire in Debian archive
>>>    - tag sbsa-ref tests as TCG only
>>>    - build the correct microblaze for avocado-system-ubuntu
>>>    - add optional flaky tests job to CI
>>>
>>> ----------------------------------------------------------------
>>> Alex Bennée (6):
>>>        gdbstub: use a better signal when we halt for IO reasons
>>>        docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS
>>>        tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test
>> This patch has been posted 5h ago and we are still discussing it...
>> I'm quite surprised you include it in your PR.
>
> Do you mind re-posting your PR without this patch? I don't
> mind to work on it during the WE and merge it let's say
> Sunday, if you want it in before this Monday.

I've sent v2 of the PR without the mips changes.