[v3] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

This log message is necessary for debugging, so enable it by default to
debug issues that are hard to reproduce locally.

Signed-off-by: Pin-yen Lin <treapking@chromium.org>

---

Changes in v3:
- Only print the warning when -ETIMEDOUT or not in tuning process

Changes in v2:
- Use dev_warn() instead of dev_err()

 drivers/mmc/host/mtk-sd.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

On Fri, 2023-12-01 at 18:26 +0800, Pin-yen Lin wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  This log message is necessary for debugging, so enable it by default
> to
> debug issues that are hard to reproduce locally.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 
Reviewed-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
> 
> Changes in v3:
> - Only print the warning when -ETIMEDOUT or not in tuning process
> 
> Changes in v2:
> - Use dev_warn() instead of dev_err()
> 
>  drivers/mmc/host/mtk-sd.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..6ae5e0a9fca9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct
> msdc_host *host)
>  
>  static void msdc_track_cmd_data(struct msdc_host *host, struct
> mmc_command *cmd)
>  {
> -	if (host->error)
> -		dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> -			__func__, cmd->opcode, cmd->arg, host->error);
> +	if (host->error &&
> +	    ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
> +	     cmd->error == -ETIMEDOUT))
> +		dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> +			 __func__, cmd->opcode, cmd->arg, host->error);
>  }
>  
>  static void msdc_request_done(struct msdc_host *host, struct
> mmc_request *mrq)
> -- 
> 2.43.0.rc2.451.g8631bc7472-goog
>

Il 01/12/23 11:26, Pin-yen Lin ha scritto:
> This log message is necessary for debugging, so enable it by default to
> debug issues that are hard to reproduce locally.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

On Fri, 1 Dec 2023 at 11:27, Pin-yen Lin <treapking@chromium.org> wrote:
>
> This log message is necessary for debugging, so enable it by default to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


>
> ---
>
> Changes in v3:
> - Only print the warning when -ETIMEDOUT or not in tuning process
>
> Changes in v2:
> - Use dev_warn() instead of dev_err()
>
>  drivers/mmc/host/mtk-sd.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..6ae5e0a9fca9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1149,9 +1149,11 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)
>
>  static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
>  {
> -       if (host->error)
> -               dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> -                       __func__, cmd->opcode, cmd->arg, host->error);
> +       if (host->error &&
> +           ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
> +            cmd->error == -ETIMEDOUT))
> +               dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> +                        __func__, cmd->opcode, cmd->arg, host->error);
>  }
>
>  static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>