| Message ID | 20231202041651.719963-1-alkuor@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: iio: temperature: Add AMS AS6200 | expand |
On Mon, 4 Dec 2023 21:19:22 -0500 Abdel Alkuor <alkuor@gmail.com> wrote: > On Sun, Dec 03, 2023 at 11:24:31AM +0000, Conor Dooley wrote: > > On Fri, Dec 01, 2023 at 11:16:50PM -0500, Abdel Alkuor wrote: > > > as6200 is high accuracy temperature sensor of -/+ 0.4C degree > > > Hi Conor, > > Is +/- 0.4 degrees really "high accuracy"? > > > That's what the datasheet says :D. I'll remove it. I'd not noticed this. Why is this an IIO driver rather than an hwmon one? Mostly we do that only for very high accuracy or weird temperature sensors (infrared ones for example or things with complex thermocouple handling). Simpler devices meant for hardware monitoring type applications typically go in hwmon. We have the iio to hwmon bridge driver for things that naturally have uses where IIO features are needed, but which get used for hwmon sometimes. Not sure this is enough IIO focused though, so perhaps list out why you think it should be in IIO? Jonathan
diff --git a/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml b/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml new file mode 100644 index 000000000000..a1817795cdca --- /dev/null +++ b/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/temperature/ams,as6200.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AMS AS6200 Temperature Sensor + +maintainers: + - Abdel Alkuor <alkuor@gmail.com> + +description: | + https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf + +properties: + compatible: + const: ams,as6200 + + reg: + maxItems: 1 + + vdd-supply: true + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@48 { + compatible = "ams,as6200"; + reg = <0x48>; + vdd-supply = <&vdd>; + interrupt-parent = <&gpio1>; + interrupts = <17 IRQ_TYPE_EDGE_BOTH>; + }; + }; +...
as6200 is high accuracy temperature sensor of -/+ 0.4C degree with a range between -40C to 125C degrees Signed-off-by: Abdel Alkuor <alkuor@gmail.com> --- Changes in v2: - Add vdd-supply .../bindings/iio/temperature/ams,as6200.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml