[v2] arm64: defconfig: enable common modules for power management

Message ID 1472705469-25599-1-git-send-email-leo.yan@linaro.org
State New
Headers show

Commit Message

Leo Yan Sept. 1, 2016, 4:51 a.m.
Enable common modules for power management; one is to enable
CPUFREQ_DT driver; the driver is used by many platforms by passing OPP
table from device tree.

Also enables thermal related drivers. Firstly we need enable
configuration CPU_THERMAL for CPU cooling device driver, this will bind
thermal zone with CPU cooling device; and enable 'power allocator'
thermal governor.

Signed-off-by: Leo Yan <leo.yan@linaro.org>

---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

-- 
1.9.1

Comments

Leo Yan Sept. 1, 2016, 5:03 a.m. | #1
Hi Catalin, Will,

On Thu, Sep 01, 2016 at 12:51:09PM +0800, Leo Yan wrote:
> Enable common modules for power management; one is to enable

> CPUFREQ_DT driver; the driver is used by many platforms by passing OPP

> table from device tree.

> 

> Also enables thermal related drivers. Firstly we need enable

> configuration CPU_THERMAL for CPU cooling device driver, this will bind

> thermal zone with CPU cooling device; and enable 'power allocator'

> thermal governor.


This patch is an updated version for [1] with enabling "power
allocator". Sorry for regression.

[1] http://archive.arm.linux.org.uk/lurker/message/20160831.085017.a42c57fe.en.html

Thanks,
Leo Yan

> 

> Signed-off-by: Leo Yan <leo.yan@linaro.org>

> ---

>  arch/arm64/configs/defconfig | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

> index eadf485..c4f5948 100644

> --- a/arch/arm64/configs/defconfig

> +++ b/arch/arm64/configs/defconfig

> @@ -82,6 +82,7 @@ CONFIG_COMPAT=y

>  CONFIG_CPU_IDLE=y

>  CONFIG_ARM_CPUIDLE=y

>  CONFIG_CPU_FREQ=y

> +CONFIG_CPUFREQ_DT=y

>  CONFIG_ARM_BIG_LITTLE_CPUFREQ=y

>  CONFIG_ARM_SCPI_CPUFREQ=y

>  CONFIG_NET=y

> @@ -252,6 +253,8 @@ CONFIG_SENSORS_INA2XX=m

>  CONFIG_SENSORS_ARM_SCPI=y

>  CONFIG_THERMAL=y

>  CONFIG_THERMAL_EMULATION=y

> +CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y

> +CONFIG_CPU_THERMAL=y

>  CONFIG_EXYNOS_THERMAL=y

>  CONFIG_WATCHDOG=y

>  CONFIG_RENESAS_WDT=y

> -- 

> 1.9.1

>
Arnd Bergmann Sept. 1, 2016, 7:33 a.m. | #2
On Thursday, September 1, 2016 12:51:09 PM CEST Leo Yan wrote:
> Enable common modules for power management; one is to enable

> CPUFREQ_DT driver; the driver is used by many platforms by passing OPP

> table from device tree.

> 

> Also enables thermal related drivers. Firstly we need enable

> configuration CPU_THERMAL for CPU cooling device driver, this will bind

> thermal zone with CPU cooling device; and enable 'power allocator'

> thermal governor.

> 

> Signed-off-by: Leo Yan <leo.yan@linaro.org>

> 


Looks good,

Acked-by: Arnd Bergmann <arnd@arndb.de>


Catalin and Will: I never know who should merge this kind of patch
as we have a number of other arm64 defconfig patches going through
arm-soc, but this patch is not really platform specific.

Do you want to pick it up in the arm64 tree or should we take
this and others patches like it in general?

	Arnd
Will Deacon Sept. 8, 2016, 10:20 a.m. | #3
Hi Arnd,

On Thu, Sep 01, 2016 at 09:33:38AM +0200, Arnd Bergmann wrote:
> On Thursday, September 1, 2016 12:51:09 PM CEST Leo Yan wrote:

> > Enable common modules for power management; one is to enable

> > CPUFREQ_DT driver; the driver is used by many platforms by passing OPP

> > table from device tree.

> > 

> > Also enables thermal related drivers. Firstly we need enable

> > configuration CPU_THERMAL for CPU cooling device driver, this will bind

> > thermal zone with CPU cooling device; and enable 'power allocator'

> > thermal governor.

> > 

> > Signed-off-by: Leo Yan <leo.yan@linaro.org>

> > 

> 

> Looks good,

> 

> Acked-by: Arnd Bergmann <arnd@arndb.de>

> 

> Catalin and Will: I never know who should merge this kind of patch

> as we have a number of other arm64 defconfig patches going through

> arm-soc, but this patch is not really platform specific.

> 

> Do you want to pick it up in the arm64 tree or should we take

> this and others patches like it in general?


I'm perfectly happy with you taking this, but thanks for asking the
question. I think that, outside of the architectural bits, it makes
sense for arm-soc to manage config options that are requested by the
submaintainers. It also helps reduce defconfig churn. I typically wait
until -rc1 before making any .config changes, unless they're urgent
(e.g. systemd suddenly starts needing some options enabled in order to
boot), so if you queue this for the merge window then we should be good.

Will
Arnd Bergmann Sept. 14, 2016, 10:08 p.m. | #4
On Thursday, September 8, 2016 11:20:35 AM CEST Will Deacon wrote:
> Hi Arnd,

> 

> On Thu, Sep 01, 2016 at 09:33:38AM +0200, Arnd Bergmann wrote:

> > On Thursday, September 1, 2016 12:51:09 PM CEST Leo Yan wrote:

> > > Enable common modules for power management; one is to enable

> > > CPUFREQ_DT driver; the driver is used by many platforms by passing OPP

> > > table from device tree.

> > > 

> > > Also enables thermal related drivers. Firstly we need enable

> > > configuration CPU_THERMAL for CPU cooling device driver, this will bind

> > > thermal zone with CPU cooling device; and enable 'power allocator'

> > > thermal governor.

> > > 

> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>

> > > 

> > 

> > Looks good,

> > 

> > Acked-by: Arnd Bergmann <arnd@arndb.de>

> > 

> > Catalin and Will: I never know who should merge this kind of patch

> > as we have a number of other arm64 defconfig patches going through

> > arm-soc, but this patch is not really platform specific.

> > 

> > Do you want to pick it up in the arm64 tree or should we take

> > this and others patches like it in general?

> 

> I'm perfectly happy with you taking this, but thanks for asking the

> question. I think that, outside of the architectural bits, it makes

> sense for arm-soc to manage config options that are requested by the

> submaintainers. It also helps reduce defconfig churn. I typically wait

> until -rc1 before making any .config changes, unless they're urgent

> (e.g. systemd suddenly starts needing some options enabled in order to

> boot), so if you queue this for the merge window then we should be good.


Ok, thanks for the detailed answer. I've applied the patch to our
next/arm64 branch now.

	Arnd

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index eadf485..c4f5948 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -82,6 +82,7 @@  CONFIG_COMPAT=y
 CONFIG_CPU_IDLE=y
 CONFIG_ARM_CPUIDLE=y
 CONFIG_CPU_FREQ=y
+CONFIG_CPUFREQ_DT=y
 CONFIG_ARM_BIG_LITTLE_CPUFREQ=y
 CONFIG_ARM_SCPI_CPUFREQ=y
 CONFIG_NET=y
@@ -252,6 +253,8 @@  CONFIG_SENSORS_INA2XX=m
 CONFIG_SENSORS_ARM_SCPI=y
 CONFIG_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
+CONFIG_THERMAL_GOV_POWER_ALLOCATOR=y
+CONFIG_CPU_THERMAL=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
 CONFIG_RENESAS_WDT=y