| Message ID | 1472729861-19360-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Baoyou,
[auto build test ERROR on arm-soc/for-next]
[also build test ERROR on v4.8-rc4]
[cannot apply to usb/usb-testing next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/Baoyou-Xie/USB-core-add-missing-header-dependencies/20160901-194228
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node'
struct device_node *usb_of_get_child_node(struct device_node *parent,
^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/core/of.c:21:0:
include/linux/usb/of.h:36:35: note: previous definition of 'usb_of_get_child_node' was here
static inline struct device_node *usb_of_get_child_node
^~~~~~~~~~~~~~~~~~~~~
vim +/usb_of_get_child_node +32 drivers/usb/core/of.c
69bec725 Peter Chen 2016-02-19 26 * @portnum: the port number which device is connecting
69bec725 Peter Chen 2016-02-19 27 *
69bec725 Peter Chen 2016-02-19 28 * Find the node from device tree according to its port number.
69bec725 Peter Chen 2016-02-19 29 *
69bec725 Peter Chen 2016-02-19 30 * Return: On success, a pointer to the device node, %NULL on failure.
69bec725 Peter Chen 2016-02-19 31 */
69bec725 Peter Chen 2016-02-19 @32 struct device_node *usb_of_get_child_node(struct device_node *parent,
69bec725 Peter Chen 2016-02-19 33 int portnum)
69bec725 Peter Chen 2016-02-19 34 {
69bec725 Peter Chen 2016-02-19 35 struct device_node *node;
:::::: The code at line 32 was first introduced by commit
:::::: 69bec725985324e79b1c47ea287815ac4ddb0521 USB: core: let USB device know device node
:::::: TO: Peter Chen <peter.chen@freescale.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c index 2289700..3de4f88 100644 --- a/drivers/usb/core/of.c +++ b/drivers/usb/core/of.c @@ -18,6 +18,7 @@ */ #include <linux/of.h> +#include <linux/usb/of.h> /** * usb_of_get_child_node - Find the device node match port number
We get 1 warning when building kernel with W=1: drivers/usb/core/of.c:31:21: warning: no previous prototype for 'usb_of_get_child_node' [-Wmissing-prototypes] In fact, this function is declared in linux/usb/of.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/usb/core/of.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4