| Message ID | 1473148597-25478-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 6 September 2016 at 01:56, Baoyou Xie <baoyou.xie@linaro.org> wrote: > We get 1 warning when building kernel with W=1: > drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes] > > In fact, this function is declared in coresight-etm-perf.h, so this patch > add missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index 755125f..d936e82 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -28,6 +28,7 @@ > #include <linux/workqueue.h> > > #include "coresight-priv.h" > +#include "coresight-etm-perf.h" I already fixed this one in my next branch - it will show up in the 4.9 cycle. Thanks for the submission, Mathieu > > static struct pmu etm_pmu; > static bool etm_perf_up; > -- > 2.7.4 >
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c index 755125f..d936e82 100644 --- a/drivers/hwtracing/coresight/coresight-etm-perf.c +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c @@ -28,6 +28,7 @@ #include <linux/workqueue.h> #include "coresight-priv.h" +#include "coresight-etm-perf.h" static struct pmu etm_pmu; static bool etm_perf_up;
We get 1 warning when building kernel with W=1: drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes] In fact, this function is declared in coresight-etm-perf.h, so this patch add missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/hwtracing/coresight/coresight-etm-perf.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4