| Message ID | 8a61e229-5388-46c7-919a-4d18cc7362b2@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] leds: trigger: panic: don't register panic notifier if creating the trigger failed | expand |
On Sat, 16 Dec 2023 21:05:33 +0100, Heiner Kallweit wrote: > It doesn't make sense to register the panic notifier if creating the > panic trigger failed. > > Applied, thanks! [1/1] leds: trigger: panic: don't register panic notifier if creating the trigger failed commit: afacb21834bb02785ddb0c3ec197208803b74faa -- Lee Jones [李琼斯]
diff --git a/drivers/leds/trigger/ledtrig-panic.c b/drivers/leds/trigger/ledtrig-panic.c index 64abf2e91..72297a845 100644 --- a/drivers/leds/trigger/ledtrig-panic.c +++ b/drivers/leds/trigger/ledtrig-panic.c @@ -64,10 +64,13 @@ static long led_panic_blink(int state) static int __init ledtrig_panic_init(void) { + led_trigger_register_simple("panic", &trigger); + if (!trigger) + return -ENOMEM; + atomic_notifier_chain_register(&panic_notifier_list, &led_trigger_panic_nb); - led_trigger_register_simple("panic", &trigger); panic_blink = led_panic_blink; return 0; }
It doesn't make sense to register the panic notifier if creating the panic trigger failed. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- v2: - don't ignore error and return -ENOMEM if creating the trigger failed --- drivers/leds/trigger/ledtrig-panic.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)