diff mbox series

[1/2] ASoC: dt-bindings: fsl-sai: Add power-domains

Message ID 20231219122957.3358149-1-alexander.stein@ew.tq-group.com
State Accepted
Commit 7084f0de2322d85f9802710b008da5c9e5e75222
Headers show
Series [1/2] ASoC: dt-bindings: fsl-sai: Add power-domains | expand

Commit Message

Alexander Stein Dec. 19, 2023, 12:29 p.m. UTC
Some SoC like i.MX8QXP use a power-domain for this IP, so add it to the
supported properties.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/sound/fsl,sai.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Dec. 20, 2023, 3:48 p.m. UTC | #1
On 19/12/2023 13:29, Alexander Stein wrote:
> On SoC like i.MX8QXP some SAI IP cores support only Rx path. Allow
> specifying only an Rx DMA channel, while omitting the Tx one.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> The feature list in reference manual IMX8DQXPRM Rev. 0 05/2020
> section 1.1.2 "Features" explicitly state that SAI2 and SAI3 is
> receive only.
> 

Why aren't you constraining it per variant/device? If only some have one
DMA channel, then I would normally expect allOf:if:then narrowing it for
each device.

Best regards,
Krzysztof
Mark Brown Jan. 22, 2024, 9:08 p.m. UTC | #2
On Tue, 19 Dec 2023 13:29:56 +0100, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP, so add it to the
> supported properties.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: fsl-sai: Add power-domains
      commit: 7084f0de2322d85f9802710b008da5c9e5e75222
[2/2] ASoC: dt-bindings: fsl-sai: Support Rx-only SAI
      commit: b6ea4284c7e756fab5f78f0129acdb74b35d759f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
index 088c26b001cc..e90286f9b5fd 100644
--- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
@@ -75,6 +75,9 @@  properties:
           - const: pll11k
         minItems: 4
 
+  power-domains:
+    maxItems: 1
+
   dmas:
     items:
       - description: DMA controller phandle and request line for RX