| Message ID | 20231220165423.v2.13.I2ee94aede9e25932f656c2bdb832be3199fa1291@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Improve IRQ wake capability reporting and update the cros_ec driver to use it | expand |
Hi, On Wed, Dec 20, 2023 at 3:55 PM Mark Hasemeyer <markhas@chromium.org> wrote: > > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to match expected behavior. > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> > --- > > Changes in v2: > -Split by arch/soc > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + > 1 file changed, 1 insertion(+) It's hard to get context with just the dts patches, but digging up the cover letter and other patches from lore I see you point at `Documentation/devicetree/bindings/power/wakeup-source.txt` which says that devices that can wakeup should have this property. ...and our EC can wake us up, so this looks right from that point of view. Also the yaml file for cros-ec says it's fine to have this property. I think it was used when things were connected via i2c since the i2c subsystem needed it. ...so from a bindings perspective it also seems fine to me. ...and looking at the code in Linux, I guess things work today because cros_ec_spi_probe() unconditionally calls device_init_wakeup(). ...but even with the code today I believe it should be fine to add this property. So with all that, this patch looks fine to me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 46aaeba286047..f3a6da8b28901 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -649,6 +649,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&ap_ec_int_l>; spi-max-frequency = <3000000>; + wakeup-source; cros_ec_pwm: pwm { compatible = "google,cros-ec-pwm";
The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined. Add the wakeup-source property to all cros-ec-spi compatible device nodes to match expected behavior. Signed-off-by: Mark Hasemeyer <markhas@chromium.org> --- Changes in v2: -Split by arch/soc arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + 1 file changed, 1 insertion(+)