diff mbox

[v6,4/5] gpio: pca953x: remove an unused variable

Message ID 1473412658-13120-5-git-send-email-bgolaszewski@baylibre.com
State Accepted
Commit 60f547be82acd3ab5369caf981280a2f13b403e9
Headers show

Commit Message

Bartosz Golaszewski Sept. 9, 2016, 9:17 a.m. UTC 
The chip_type variable in struct pca953x_chip is no longer required.

Remove it.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

---
 drivers/gpio/gpio-pca953x.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.7.4

Comments

Linus Walleij Sept. 12, 2016, 12:49 p.m. UTC | #1 
On Fri, Sep 9, 2016 at 11:17 AM, Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:

> The chip_type variable in struct pca953x_chip is no longer required.

>

> Remove it.

>

> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Patch applied.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index e7bf3b3..e36a9bf 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -130,7 +130,6 @@  struct pca953x_chip {
 	struct i2c_client *client;
 	struct gpio_chip gpio_chip;
 	const char *const *names;
-	int	chip_type;
 	unsigned long driver_data;
 	struct regulator *regulator;
 
@@ -791,8 +790,6 @@  static int pca953x_probe(struct i2c_client *client,
 		}
 	}
 
-	chip->chip_type = PCA_CHIP_TYPE(chip->driver_data);
-
 	mutex_init(&chip->i2c_lock);
 
 	/* initialize cached registers from their original values.
@@ -814,7 +811,7 @@  static int pca953x_probe(struct i2c_client *client,
 		chip->read_regs = pca953x_read_regs_16;
 	}
 
-	if (chip->chip_type == PCA953X_TYPE)
+	if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE)
 		ret = device_pca953x_init(chip, invert);
 	else
 		ret = device_pca957x_init(chip, invert);