From patchwork Fri Sep 9 11:34:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 75882 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp296837qgf; Fri, 9 Sep 2016 04:35:08 -0700 (PDT) X-Received: by 10.98.99.67 with SMTP id x64mr5778895pfb.26.1473420908048; Fri, 09 Sep 2016 04:35:08 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xz3si3556919pab.244.2016.09.09.04.35.07; Fri, 09 Sep 2016 04:35:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbcIILfG (ORCPT + 14 others); Fri, 9 Sep 2016 07:35:06 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35340 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbcIILfF (ORCPT ); Fri, 9 Sep 2016 07:35:05 -0400 Received: by mail-pf0-f178.google.com with SMTP id w87so28791300pfk.2 for ; Fri, 09 Sep 2016 04:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u3IqFei3wDhDNPvKMWnMne9XXMl92dAZY3fz7KJJ9FU=; b=FgLFQ9niL+xQd42DoFHA05t3TnzeZDdhaBk/DC+TnOpX+K+Cu9Nx4bQna91WsWqPUx wfFzUQqugIngHvRtIxMMxf1gFv1X+RCpOuRCfeyahamqrv66T6NhaRSpwqbZdYEBZIF/ IuvoNU7uvRtX3eojuEIfKWoG+bxKIeQl744Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u3IqFei3wDhDNPvKMWnMne9XXMl92dAZY3fz7KJJ9FU=; b=Q1UBJucZlp5C5DYtjDguF6Xkr+qtCARlE5y77UsIc77SenZLzgwLW3ctsulpOYIrsz HayQMKe/Oritid1GvC7TqAY2sSSWoO37zMwWq6U1SVHeossxWT6W73MuQngELfrEKJGb dTikhkfGLRq71wf1zNhPEm17iku2kt4+ZGnOdFB1n8GDuaTP+3lvXc2qdfXEij/0v6no PdHfgZqGppG0CVcsSFdNLbOplwiqJxJ15Oq/BryaBwd6zpBVxvI84wygxP8mh2hUfIig fwkEyJKynfllsCWbu+jpMrhzTmz/SyuVjZhz6iwBFMsBeAbxLRbhSoGLi8Hl9X20Q6k1 FPYQ== X-Gm-Message-State: AE9vXwOljDmWgT1qv/meMYR7MTrdPshoBX7IOrACpIGwVccfcSQyA+QbMolr9DGBYGuXKwNo X-Received: by 10.98.15.86 with SMTP id x83mr5673905pfi.129.1473420904811; Fri, 09 Sep 2016 04:35:04 -0700 (PDT) Received: from localhost ([171.61.121.167]) by smtp.gmail.com with ESMTPSA id c18sm4742843pfc.40.2016.09.09.04.35.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Sep 2016 04:35:01 -0700 (PDT) Date: Fri, 9 Sep 2016 17:04:59 +0530 From: Viresh Kumar To: Russell King - ARM Linux Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] cpufreq: create link to policy only for registered CPUs Message-ID: <20160909113459.GG18547@vireshk-i7> References: <20160819110032.GM1041@n2100.armlinux.org.uk> <20160909111620.GQ1041@n2100.armlinux.org.uk> <20160909112204.GE18547@vireshk-i7> <20160909112841.GS1041@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160909112841.GS1041@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 09-09-16, 12:28, Russell King - ARM Linux wrote: > On Fri, Sep 09, 2016 at 04:52:04PM +0530, Viresh Kumar wrote: > > Thanks for testing it.. You need another patch from Rafael, which > > should be in linux-next by now.. > > > > commit 3689ad7ed6a8 ("cpufreq: Drop unnecessary check from > > cpufreq_policy_alloc()") > > > > Both patches combined will fix the problem you were getting. > > Please send me this other patch. Seems absurd to fix a reported problem > without copying appropriate patches to the reporter... It got merged separately, and yes you should have been cc'd for that as well. Please find it attached now.. -- viresh >From 3689ad7ed6a836c4eec5e7bdd17a11a79591bef9 Mon Sep 17 00:00:00 2001 Message-Id: <3689ad7ed6a836c4eec5e7bdd17a11a79591bef9.1473420826.git.viresh.kumar@linaro.org> From: "Rafael J. Wysocki" Date: Wed, 31 Aug 2016 03:11:31 +0200 Subject: [PATCH] cpufreq: Drop unnecessary check from cpufreq_policy_alloc() Since cpufreq_policy_alloc() doesn't use its dev variable for anything useful, drop that variable from there along with the NULL check against it. Signed-off-by: Rafael J. Wysocki Acked-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 3dd4884c6f9e..13fb589b6d2c 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1073,13 +1073,9 @@ static void handle_update(struct work_struct *work) static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) { - struct device *dev = get_cpu_device(cpu); struct cpufreq_policy *policy; int ret; - if (WARN_ON(!dev)) - return NULL; - policy = kzalloc(sizeof(*policy), GFP_KERNEL); if (!policy) return NULL; -- 2.7.1.410.g6faf27b