| Message ID | 20240103173349.398526-11-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing and plugin updates for 9.0 (pre-PR) | expand |
Hi Daniel, On 3/1/24 18:33, Alex Bennée wrote: > From: Daniel P. Berrangé <berrange@redhat.com> > > The pxe-test uses the boot_sector_test() function, and that already > uses a timeout of 600 seconds. So adjust the timeout on the meson > side accordingly. IIRC few years ago you said tests running on CI ('Tier-1') should respect a time limit. IMO 10min seems too much for CI, should this test be skipped there? > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > [thuth: Bump timeout to 600s and adjust commit description] > Signed-off-by: Thomas Huth <thuth@redhat.com> > Message-Id: <20231215070357.10888-7-thuth@redhat.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/qtest/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 7a4160df046..ec93d5a384f 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -4,6 +4,7 @@ slow_qtests = { > 'npcm7xx_pwm-test': 300, > 'qom-test' : 900, > 'test-hmp' : 240, > + 'pxe-test': 600, > } > > qtests_generic = [
On Wed, Jan 03, 2024 at 06:43:52PM +0100, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 3/1/24 18:33, Alex Bennée wrote: > > From: Daniel P. Berrangé <berrange@redhat.com> > > > > The pxe-test uses the boot_sector_test() function, and that already > > uses a timeout of 600 seconds. So adjust the timeout on the meson > > side accordingly. > > IIRC few years ago you said tests running on CI ('Tier-1') should > respect a time limit. IMO 10min seems too much for CI, should this > test be skipped there? This isn't going to take 10 minutes in reality. We're setting timeouts such that we avoid false-failures in the extreme worst case scenarios. > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > [thuth: Bump timeout to 600s and adjust commit description] > > Signed-off-by: Thomas Huth <thuth@redhat.com> > > Message-Id: <20231215070357.10888-7-thuth@redhat.com> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > --- > > tests/qtest/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > > index 7a4160df046..ec93d5a384f 100644 > > --- a/tests/qtest/meson.build > > +++ b/tests/qtest/meson.build > > @@ -4,6 +4,7 @@ slow_qtests = { > > 'npcm7xx_pwm-test': 300, > > 'qom-test' : 900, > > 'test-hmp' : 240, > > + 'pxe-test': 600, > > } > > qtests_generic = [ > With regards, Daniel
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 7a4160df046..ec93d5a384f 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -4,6 +4,7 @@ slow_qtests = { 'npcm7xx_pwm-test': 300, 'qom-test' : 900, 'test-hmp' : 240, + 'pxe-test': 600, } qtests_generic = [