| Message ID | 20240111112450.1727866-1-valentin.caron@foss.st.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: serial: stm32: add power-domains property | expand |
On 11/01/2024 12:24, Valentin Caron wrote: > Add "power-domains" property in stm32 serial binding to avoid: > > serial@40010000: Unevaluated properties are not allowed > ('power-domains' were unexpected) > It would be better if you checked whether it can be part of power domain or not. What if the DTS is wrong? Best regards, Krzysztof
On 1/15/24 16:05, Krzysztof Kozlowski wrote: > On 11/01/2024 12:24, Valentin Caron wrote: >> Add "power-domains" property in stm32 serial binding to avoid: >> >> serial@40010000: Unevaluated properties are not allowed >> ('power-domains' were unexpected) >> > It would be better if you checked whether it can be part of power domain > or not. What if the DTS is wrong? > > Best regards, > Krzysztof > Hi Krzysztof, I'm not sure to understand, but if you mean that there is no power-domains properties right now in all stm32mp device trees and so it does not required to add this stm32 serial bindings: Theses will be upstreamed in the future, and because power-domains property is optional, I can add it right now in stm32 serial binding to anticipate. Best regards, Valentin
On 17/01/2024 10:21, Valentin CARON wrote: > > On 1/15/24 16:05, Krzysztof Kozlowski wrote: >> On 11/01/2024 12:24, Valentin Caron wrote: >>> Add "power-domains" property in stm32 serial binding to avoid: >>> >>> serial@40010000: Unevaluated properties are not allowed >>> ('power-domains' were unexpected) >>> >> It would be better if you checked whether it can be part of power domain >> or not. What if the DTS is wrong? >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > I'm not sure to understand, but if you mean that there is no > power-domains properties right now in all stm32mp device trees > and so it does not required to add this stm32 serial bindings: > > Theses will be upstreamed in the future, and because power-domains > property is optional, I can add it right now in stm32 serial binding > to anticipate. No. You used argument: "add because DTS has it" and I want different argument: "add because it is the right thing to do because foo and bar". If DTS is wrong, then your commit and this explanation is wrong. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml index 1df8ffe95fc6..62f97da1b2fd 100644 --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml @@ -58,6 +58,9 @@ properties: wakeup-source: true + power-domains: + maxItems: 1 + rx-threshold: description: If value is set to 1, RX FIFO threshold is disabled.
Add "power-domains" property in stm32 serial binding to avoid: serial@40010000: Unevaluated properties are not allowed ('power-domains' were unexpected) Signed-off-by: Valentin Caron <valentin.caron@foss.st.com> --- Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 +++ 1 file changed, 3 insertions(+)