| Message ID | 20240118133022.553339-3-amadeus@jmu.edu.cn |
|---|---|
| State | Accepted |
| Commit | 5db216f6e1f85394e79dca74ceceb83b2f8566b5 |
| Headers | show |
| Series | arm64: dts: qcom: ipq6018: enable sdhci node | expand |
On Thu, Jan 18, 2024 at 09:30:22PM +0800, Chukun Pan wrote: > Enable mmc device found on ipq6018 devices. > This node supports both eMMC and SD cards. > > Tested with: > eMMC (HS200) > SD Card (SDR50/SDR104) > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 322eced0b876..420c192bccd9 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -441,6 +441,25 @@ dwc_1: usb@7000000 { > }; > }; > > + sdhc: mmc@7804000 { > + compatible = "qcom,ipq6018-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x0 0x7804000 0x0 0x1000>, > + <0x0 0x7805000 0x0 0x1000>; > + reg-names = "hc", "cqhci"; > + > + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "hc_irq", "pwr_irq"; > + > + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > + <&gcc GCC_SDCC1_APPS_CLK>, > + <&xo>; > + clock-names = "iface", "core", "xo"; > + resets = <&gcc GCC_SDCC1_BCR>; > + max-frequency = <192000000>; > + status = "disabled"; Subject and commit message says "enable", but this says disable. Could you change this to "Add" instead? Do you have a patch for any board where this is actually enabled? Perhaps you missed a 3rd patch that enables this and uses the ipq6018_l2 regulator you add in patch 1? Regards, Bjorn > + }; > + > blsp_dma: dma-controller@7884000 { > compatible = "qcom,bam-v1.7.0"; > reg = <0x0 0x07884000 0x0 0x2b000>; > -- > 2.25.1 >
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 322eced0b876..420c192bccd9 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -441,6 +441,25 @@ dwc_1: usb@7000000 { }; }; + sdhc: mmc@7804000 { + compatible = "qcom,ipq6018-sdhci", "qcom,sdhci-msm-v5"; + reg = <0x0 0x7804000 0x0 0x1000>, + <0x0 0x7805000 0x0 0x1000>; + reg-names = "hc", "cqhci"; + + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hc_irq", "pwr_irq"; + + clocks = <&gcc GCC_SDCC1_AHB_CLK>, + <&gcc GCC_SDCC1_APPS_CLK>, + <&xo>; + clock-names = "iface", "core", "xo"; + resets = <&gcc GCC_SDCC1_BCR>; + max-frequency = <192000000>; + status = "disabled"; + }; + blsp_dma: dma-controller@7884000 { compatible = "qcom,bam-v1.7.0"; reg = <0x0 0x07884000 0x0 0x2b000>;
Enable mmc device found on ipq6018 devices. This node supports both eMMC and SD cards. Tested with: eMMC (HS200) SD Card (SDR50/SDR104) Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)