diff mbox series

[v2,3/3] mfd: cros_ec: Register EC-based watchdog subdevice

Message ID 20240118195325.2964918-4-lma@chromium.org
State Superseded
Headers show
Series Introduce EC-based watchdog | expand

Commit Message

Łukasz Majczak Jan. 18, 2024, 7:53 p.m. UTC
Add ChromeOS EC-based watchdog as EC subdevice.

Signed-off-by: Lukasz Majczak <lma@chromium.org>
---
 drivers/mfd/cros_ec_dev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Guenter Roeck Jan. 18, 2024, 11:44 p.m. UTC | #1
On Thu, Jan 18, 2024 at 07:53:24PM +0000, Lukasz Majczak wrote:
> Add ChromeOS EC-based watchdog as EC subdevice.
> 
> Signed-off-by: Lukasz Majczak <lma@chromium.org>
> ---
>  drivers/mfd/cros_ec_dev.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 603b1cd52785..d0140a285f69 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -91,6 +91,10 @@ static const struct mfd_cell cros_usbpd_notify_cells[] = {
>  	{ .name = "cros-usbpd-notify", },
>  };
>  
> +static const struct mfd_cell cros_ec_wdt_cells[] = {
> +	{ .name = "cros-ec-wdt-drv", }

Assuming you drop "-drv",

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Thanks,
Guenter
Łukasz Majczak Jan. 19, 2024, 8:36 a.m. UTC | #2
> Assuming you drop "-drv",
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks,
> Guenter

I will do so, thank you.

Best regards,
Lukasz
diff mbox series

Patch

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 603b1cd52785..d0140a285f69 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -91,6 +91,10 @@  static const struct mfd_cell cros_usbpd_notify_cells[] = {
 	{ .name = "cros-usbpd-notify", },
 };
 
+static const struct mfd_cell cros_ec_wdt_cells[] = {
+	{ .name = "cros-ec-wdt-drv", }
+};
+
 static const struct cros_feature_to_cells cros_subdevices[] = {
 	{
 		.id		= EC_FEATURE_CEC,
@@ -107,6 +111,11 @@  static const struct cros_feature_to_cells cros_subdevices[] = {
 		.mfd_cells	= cros_usbpd_charger_cells,
 		.num_cells	= ARRAY_SIZE(cros_usbpd_charger_cells),
 	},
+	{
+		.id		= EC_FEATURE_HANG_DETECT,
+		.mfd_cells	= cros_ec_wdt_cells,
+		.num_cells	= ARRAY_SIZE(cros_ec_wdt_cells),
+	},
 };
 
 static const struct mfd_cell cros_ec_platform_cells[] = {