diff mbox series

[v2,4/5] memory: brcmstb_dpfe: introduce version-specific compatible strings

Message ID 20240119215231.758844-5-mmayer@broadcom.com
State New
Headers show
Series memory: brcmstb_dpfe: support DPFE API v4 | expand

Commit Message

Markus Mayer Jan. 19, 2024, 9:52 p.m. UTC 
Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3
to the Broadcom DPFE driver.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
 drivers/memory/brcmstb_dpfe.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Jan. 23, 2024, 9:27 p.m. UTC | #1 
On 19/01/2024 22:52, Markus Mayer wrote:
> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3
> to the Broadcom DPFE driver.

Nothing improved here. I think my last comment was pretty clear what I
expect.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
index a7ab3d377206..a44a70d028f6 100644
--- a/drivers/memory/brcmstb_dpfe.c
+++ b/drivers/memory/brcmstb_dpfe.c
@@ -924,7 +924,20 @@  static const struct of_device_id brcmstb_dpfe_of_match[] = {
 	{ .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 },
 	{ .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 },
 	{ .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 },
-	/* API v3 is the default going forward */
+
+	/*
+	 * Match the DPFE API flavour based on a versioned compatible string
+	 * that tells us which API version the hardware speaks.
+	 */
+	{ .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 },
+	{ .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 },
+	{ .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 },
+
+	/*
+	 * This "default" compatible string should no longer be used. It has
+	 * been removed from the binding but kept here for backward
+	 * compatibility.
+	 */
 	{ .compatible = "brcm,dpfe-cpu", .data = &dpfe_api_v3 },
 	{}
 };