[36/45] tty: vt: change consw::con_set_origin() return type

Message ID	20240118075756.10541-37-jirislaby@kernel.org
State	Superseded
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FB0B2E852; Thu, 18 Jan 2024 07:59:23 +0000 (UTC) From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org> To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, Helge Deller <deller@gmx.de>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 36/45] tty: vt: change consw::con_set_origin() return type Date: Thu, 18 Jan 2024 08:57:47 +0100 Message-ID: <20240118075756.10541-37-jirislaby@kernel.org> In-Reply-To: <20240118075756.10541-1-jirislaby@kernel.org> References: <20240118075756.10541-1-jirislaby@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	tty: vt: cleanup and documentation \| expand [00/45] tty: vt: cleanup and documentation [01/45] vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta() [02/45] fbcon: make display_desc a static array in fbcon_startup() [03/45] tty: vt: fix 20 vs 0x20 typo in EScsiignore [04/45] tty: vt: expect valid vc when in tty ops [05/45] tty: vt: pass proper pointers from tioclinux() [06/45] tty: vt: push console lock from tioclinux() down to 2 functions [07/45] tty: vt: pass vc_resize_user as a parameter [08/45] tty: vt: make vc_is_sel()'s vc const [09/45] tty: vt: define an enum for CSI+m codes [10/45] tty: vt: use case ranges for CSI+m fg/bg colors [11/45] tty: vt: define an enum for CSI+J codes [12/45] tty: vt: reflow csi_J() [13/45] tty: vt: define an enum for CSI+K codes [14/45] tty: vt: reflow csi_K() [15/45] tty: vt: pass vpar as unsigned to csi_J() and csi_K() [16/45] tty: vt: define an enum for ascii characters [17/45] tty: vt: remove extern from functions in selection.h [18/45] tty: vt: make consw::con_debug_() return void [19/45] tty: vt: make init parameter of consw::con_init() a bool [20/45] tty: vt: sanitize arguments of consw::con_clear() [21/45] tty: vt: remove checks for count in consw::con_clear() implementations [22/45] tty: vt: add con_putc() helper [23/45] tty: vt: eliminate unneeded consw::con_putc() implementations [24/45] tty: vt: sanitize consw::con_putc() parameters [25/45] tty: vt: sanitize consw::con_putcs() parameters [26/45] consoles: use if instead of switch-case in consw::con_cursor() [27/45] fbdev/core: simplify cursor_state setting in fbcon_ops::cursor() [28/45] tty: vt: remove CM_ constants [29/45] tty: vt: make consw::con_switch() return a bool [30/45] tty: vt: stop using -1 for blank mode in consw::con_blank() [31/45] tty: vt: use VESA blanking constants [32/45] tty: vt: use enum for VESA blanking modes [33/45] tty: vt: make types around consw::con_blank() bool [34/45] tty: vt: make font of consw::con_font_set() const [35/45] tty: vt: make consw::con_font_default()'s name const [36/45] tty: vt: change consw::con_set_origin() return type [37/45] fbcon: remove consw::con_screen_pos() [38/45] tty: vt: remove consw::con_screen_pos() [39/45] tty: vt: make types of screenpos() more consistent [40/45] fbcon: remove fbcon_getxy() [41/45] tty: vt: remove consw::con_getxy() [42/45] tty: vt: remove unused consw::con_flush_scrollback() [43/45] tty: vt: document the rest of struct consw [44/45] tty: vt: fix up kernel-doc [45/45] Documentation: add console.rst

Message ID

20240118075756.10541-37-jirislaby@kernel.org

State

Superseded

Headers

From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	Helge Deller <deller@gmx.de>,
	linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 36/45] tty: vt: change consw::con_set_origin() return type
Date: Thu, 18 Jan 2024 08:57:47 +0100
Message-ID: <20240118075756.10541-37-jirislaby@kernel.org>
In-Reply-To: <20240118075756.10541-1-jirislaby@kernel.org>
References: <20240118075756.10541-1-jirislaby@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

tty: vt: cleanup and documentation | expand

Commit Message

Jiri Slaby Jan. 18, 2024, 7:57 a.m. UTC

The return value of consw::con_set_origin() is only true/false, meaining
if vc->vc_origin is set to vc->vc_screenbuf or not.

So switch the type and returned values accordingly.

And document the hook.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/video/console/vgacon.c | 8 ++++----
 include/linux/console.h        | 5 ++++-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index ea086b39c6f5..4a40da81990d 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -65,7 +65,7 @@  static struct vgastate vgastate;
  *  Interface used by the world
  */
 
-static int vgacon_set_origin(struct vc_data *c);
+static bool vgacon_set_origin(struct vc_data *c);
 
 static struct uni_pagedict *vgacon_uni_pagedir;
 static int vgacon_refcount;
@@ -1100,15 +1100,15 @@  static int vgacon_resize(struct vc_data *c, unsigned int width,
 	return 0;
 }
 
-static int vgacon_set_origin(struct vc_data *c)
+static bool vgacon_set_origin(struct vc_data *c)
 {
 	if (vga_is_gfx ||	/* We don't play origin tricks in graphic modes */
 	    (console_blanked && !vga_palette_blanked))	/* Nor we write to blanked screens */
-		return 0;
+		return false;
 	c->vc_origin = c->vc_visible_origin = vga_vram_base;
 	vga_set_mem_top(c);
 	vga_rolled_over = 0;
-	return 1;
+	return true;
 }
 
 static void vgacon_save_screen(struct vc_data *c)
diff --git a/include/linux/console.h b/include/linux/console.h
index 543de22a3f23..c07e1ce6bd14 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -63,6 +63,9 @@  enum vc_intensity;
  * @con_set_palette: sets the palette of the console to @table (optional)
  * @con_scrolldelta: the contents of the console should be scrolled by @lines.
  *		     Invoked by user. (optional)
+ * @con_set_origin: set origin (see &vc_data::vc_origin) of the @vc. If not
+ *		provided or returns false, the origin is set to
+ *		@vc->vc_screenbuf. (optional)
  */
 struct consw {
 	struct module *owner;
@@ -95,7 +98,7 @@  struct consw {
 	void	(*con_set_palette)(struct vc_data *vc,
 			const unsigned char *table);
 	void	(*con_scrolldelta)(struct vc_data *vc, int lines);
-	int	(*con_set_origin)(struct vc_data *vc);
+	bool	(*con_set_origin)(struct vc_data *vc);
 	void	(*con_save_screen)(struct vc_data *vc);
 	u8	(*con_build_attr)(struct vc_data *vc, u8 color,
 			enum vc_intensity intensity,

[36/45] tty: vt: change consw::con_set_origin() return type

Commit Message

Patch