diff mbox series

[v3,3/3] mfd: cros_ec: Register EC-based watchdog subdevice

Message ID 20240119084328.3135503-4-lma@chromium.org
State New
Headers show
Series Introduce EC-based watchdog | expand

Commit Message

Łukasz Majczak Jan. 19, 2024, 8:43 a.m. UTC
Add ChromeOS EC-based watchdog as EC subdevice.

Signed-off-by: Lukasz Majczak <lma@chromium.org>
---
 drivers/mfd/cros_ec_dev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Lee Jones Jan. 25, 2024, 1:37 p.m. UTC | #1
On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> Add ChromeOS EC-based watchdog as EC subdevice.
> 
> 

Applied, thanks!

[3/3] mfd: cros_ec: Register EC-based watchdog subdevice
      commit: a1958f84deb5cdba020af725fc5003a05af4819c

--
Lee Jones [李琼斯]
Łukasz Majczak Jan. 25, 2024, 1:55 p.m. UTC | #2
On Thu, Jan 25, 2024 at 2:37 PM Lee Jones <lee@kernel.org> wrote:
>
> On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> > Add ChromeOS EC-based watchdog as EC subdevice.
> >
> >
>
> Applied, thanks!
>
> [3/3] mfd: cros_ec: Register EC-based watchdog subdevice
>       commit: a1958f84deb5cdba020af725fc5003a05af4819c
>
> --
> Lee Jones [李琼斯]
>
Hi Lee,

I will send V4 of the patchset to address Krzysztof suggestions, in
that case I should skip adding V4 of this patch and have only patches
1 and 2 in the V4 patchset?

Best regards,
Lukasz
Lee Jones Jan. 26, 2024, 9:07 a.m. UTC | #3
On Thu, 25 Jan 2024, Łukasz Majczak wrote:

> On Thu, Jan 25, 2024 at 2:37 PM Lee Jones <lee@kernel.org> wrote:
> >
> > On Fri, 19 Jan 2024 08:43:27 +0000, Lukasz Majczak wrote:
> > > Add ChromeOS EC-based watchdog as EC subdevice.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [3/3] mfd: cros_ec: Register EC-based watchdog subdevice
> >       commit: a1958f84deb5cdba020af725fc5003a05af4819c
> >
> > --
> > Lee Jones [李琼斯]
> >
> Hi Lee,
> 
> I will send V4 of the patchset to address Krzysztof suggestions, in
> that case I should skip adding V4 of this patch and have only patches
> 1 and 2 in the V4 patchset?

Yes please.  No need to resend patches which have already been merged.
diff mbox series

Patch

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 603b1cd52785..4996220ce64b 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -91,6 +91,10 @@  static const struct mfd_cell cros_usbpd_notify_cells[] = {
 	{ .name = "cros-usbpd-notify", },
 };
 
+static const struct mfd_cell cros_ec_wdt_cells[] = {
+	{ .name = "cros-ec-wdt", }
+};
+
 static const struct cros_feature_to_cells cros_subdevices[] = {
 	{
 		.id		= EC_FEATURE_CEC,
@@ -107,6 +111,11 @@  static const struct cros_feature_to_cells cros_subdevices[] = {
 		.mfd_cells	= cros_usbpd_charger_cells,
 		.num_cells	= ARRAY_SIZE(cros_usbpd_charger_cells),
 	},
+	{
+		.id		= EC_FEATURE_HANG_DETECT,
+		.mfd_cells	= cros_ec_wdt_cells,
+		.num_cells	= ARRAY_SIZE(cros_ec_wdt_cells),
+	},
 };
 
 static const struct mfd_cell cros_ec_platform_cells[] = {