| Message ID | 20240124122204.730370-3-o.rempel@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | Introduction of PSCR Framework and Related Components | expand |
On 24/01/2024 13:21, Oleksij Rempel wrote: > Add binding for Power State Change Reason Recording (PSCRR) subsystem > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../bindings/power/reset/pscrr.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/pscrr.yaml > > diff --git a/Documentation/devicetree/bindings/power/reset/pscrr.yaml b/Documentation/devicetree/bindings/power/reset/pscrr.yaml > new file mode 100644 > index 000000000000..c8738b4930fe > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/pscrr.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/pscrr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Power State Change Reason (PSCR) Missing final R? > + > +maintainers: > + - Oleksij Rempel <o.rempel@pengutronix.de> > + > +description: Binding for devices responsible to store reasons for power state Line break after description: > + changes such as reboot and power-off. Reasons like unknown, under voltage, > + and over temperature are captured for diagnostic or automatic recovery > + purposes. > + > +properties: > + pscr-under-voltage: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Value to indicate an under-voltage condition of a system critical > + regulator as the reason for the power state change. I don't understand how it is supposed to work... unless you wrote binding for drivers. For drivers it would make sense, but that's another problem: binding is not for drivers. You also did not present here DTS with any actual device doing this. You just added a driver... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/reset/pscrr.yaml b/Documentation/devicetree/bindings/power/reset/pscrr.yaml new file mode 100644 index 000000000000..c8738b4930fe --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/pscrr.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/reset/pscrr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Power State Change Reason (PSCR) + +maintainers: + - Oleksij Rempel <o.rempel@pengutronix.de> + +description: Binding for devices responsible to store reasons for power state + changes such as reboot and power-off. Reasons like unknown, under voltage, + and over temperature are captured for diagnostic or automatic recovery + purposes. + +properties: + pscr-under-voltage: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Value to indicate an under-voltage condition of a system critical + regulator as the reason for the power state change. + + pscr-over-current: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Value to indicate an over-current condition of a system ctitical regulator + as the reason for the power state change. + + pscr-regulator-failure: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Value to indicate an unknown, system ctitical regulator related failure + as the reason for the power state change. + + pscr-over-temperature: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Value to indicate a system critical over-temperature condition as the + reason for the power state change. + +additionalProperties: true + +...
Add binding for Power State Change Reason Recording (PSCRR) subsystem Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../bindings/power/reset/pscrr.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/pscrr.yaml