| Message ID | 20240124121855.162730-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 915253bdd64f2372fa5f6c58d75cb99972c7401d |
| Headers | show |
| Series | arm64: dts: qcom: sm8450-hdk: correct AMIC4 and AMIC5 microphones | expand |
On Wed, 24 Jan 2024 13:18:55 +0100, Krzysztof Kozlowski wrote: > Due to lack of documentation the AMIC4 and AMIC5 analogue microphones > were never actually working, so the audio routing for them was added > hoping it is correct. It turned out not correct - their routing should > point to SWR_INPUT0 (so audio mixer TX SMIC MUX0 = SWR_MIC0) and > SWR_INPUT1 (so audio mixer TX SMIC MUX0 = SWR_MIC1), respectively. With > proper mixer settings and fixed LPASS TX macr codec TX SMIC MUXn > widgets, this makes all microphones working on HDK8450. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8450-hdk: correct AMIC4 and AMIC5 microphones commit: 915253bdd64f2372fa5f6c58d75cb99972c7401d Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts index 03fad2e698af..ce398927beb9 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts @@ -931,8 +931,8 @@ &sound { "TX DMIC3", "MIC BIAS1", "TX SWR_INPUT0", "ADC1_OUTPUT", "TX SWR_INPUT1", "ADC2_OUTPUT", - "TX SWR_INPUT2", "ADC3_OUTPUT", - "TX SWR_INPUT3", "ADC4_OUTPUT"; + "TX SWR_INPUT0", "ADC3_OUTPUT", + "TX SWR_INPUT1", "ADC4_OUTPUT"; wcd-playback-dai-link { link-name = "WCD Playback";
Due to lack of documentation the AMIC4 and AMIC5 analogue microphones were never actually working, so the audio routing for them was added hoping it is correct. It turned out not correct - their routing should point to SWR_INPUT0 (so audio mixer TX SMIC MUX0 = SWR_MIC0) and SWR_INPUT1 (so audio mixer TX SMIC MUX0 = SWR_MIC1), respectively. With proper mixer settings and fixed LPASS TX macr codec TX SMIC MUXn widgets, this makes all microphones working on HDK8450. Cc: <stable@vger.kernel.org> Fixes: f20cf2bc3f77 ("arm64: dts: qcom: sm8450-hdk: add other analogue microphones") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)