| Message ID | 1474446210-337-4-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | feb3ef714436ca74c20a6e67ab2c45d4aca1d2c1 |
| Headers | show |
On 21 September 2016 at 09:23, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > Move away from ArmPkg's BaseMemoryLibStm, which is deprecated and about > to be removed. For SEC and PEI phases, move to the generic MdePkg version > instead, and for later phases, use the accelerated BaseMemoryLibOptDxe > implementation. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Ryan Harkin <ryan.harkin@linaro.org> > --- > Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > index bfd94c3a2df4..823c934f3159 100644 > --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc > @@ -58,9 +58,7 @@ > # > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > - # 1/123 faster than Stm or Vstm version > - #BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > - BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > > # Networking Requirements > NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > @@ -192,6 +190,7 @@ > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > @@ -210,6 +209,7 @@ > > [LibraryClasses.common.SEC, LibraryClasses.common.PEIM] > MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > [LibraryClasses.common.DXE_CORE] > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > -- > 2.7.4 >
On 11 October 2016 at 13:31, Ryan Harkin <ryan.harkin@linaro.org> wrote: > On 21 September 2016 at 09:23, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: >> Move away from ArmPkg's BaseMemoryLibStm, which is deprecated and about >> to be removed. For SEC and PEI phases, move to the generic MdePkg version >> instead, and for later phases, use the accelerated BaseMemoryLibOptDxe >> implementation. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Tested-by: Ryan Harkin <ryan.harkin@linaro.org> > Pushed, thanks.
diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index bfd94c3a2df4..823c934f3159 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -58,9 +58,7 @@ # PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - # 1/123 faster than Stm or Vstm version - #BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf - BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf + BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf # Networking Requirements NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf @@ -192,6 +190,7 @@ ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf [LibraryClasses.common.PEIM] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf @@ -210,6 +209,7 @@ [LibraryClasses.common.SEC, LibraryClasses.common.PEIM] MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf [LibraryClasses.common.DXE_CORE] HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
Move away from ArmPkg's BaseMemoryLibStm, which is deprecated and about to be removed. For SEC and PEI phases, move to the generic MdePkg version instead, and for later phases, use the accelerated BaseMemoryLibOptDxe implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)