| Message ID | 1474691500-19793-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] > > In fact, this function is declared in > include/linux/platform_data/clk-realview.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > I think I commented on this one already: the only caller of the function is getting removed in v4.9, so we should remove the definition of the function subsequently in the next release. We could in theory try to remove this at the same time, but the effort to synchronize the git trees is not worth the benefit. Arnd
diff --git a/drivers/clk/versatile/clk-realview.c b/drivers/clk/versatile/clk-realview.c index c56efc7..f662fd1 100644 --- a/drivers/clk/versatile/clk-realview.c +++ b/drivers/clk/versatile/clk-realview.c @@ -10,6 +10,7 @@ #include <linux/err.h> #include <linux/io.h> #include <linux/clk-provider.h> +#include <linux/platform_data/clk-realview.h> #include "clk-icst.h"
We get 1 warning when building kernel with W=1: drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] In fact, this function is declared in include/linux/platform_data/clk-realview.h, so this patch adds missing header dependencies. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/clk/versatile/clk-realview.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4