| Message ID | 1474694882-25427-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote: > diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c > index f6ab6027..2519510 100644 > --- a/drivers/isdn/mISDN/layer2.c > +++ b/drivers/isdn/mISDN/layer2.c > @@ -459,15 +459,6 @@ IsDISC(u_char *data) > return (data[0] & 0xef) == DISC; > } > > -inline int > -IsRR(u_char *data, struct layer2 *l2) > -{ > - if (test_bit(FLG_MOD128, &l2->flag)) > - return data[0] == RR; > - else > - return (data[0] & 0xf) == 1; > -} > - > static inline int > IsSFrame(u_char *data, struct layer2 *l2) > { > -- > This is not wrong, but it might be nicer to just make this one as 'static inline' as well like the other ones for consistency. Note that static inline functions don't cause a warning when they are unused. Arnd
diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c index f6ab6027..2519510 100644 --- a/drivers/isdn/mISDN/layer2.c +++ b/drivers/isdn/mISDN/layer2.c @@ -459,15 +459,6 @@ IsDISC(u_char *data) return (data[0] & 0xef) == DISC; } -inline int -IsRR(u_char *data, struct layer2 *l2) -{ - if (test_bit(FLG_MOD128, &l2->flag)) - return data[0] == RR; - else - return (data[0] & 0xf) == 1; -} - static inline int IsSFrame(u_char *data, struct layer2 *l2) {
We get 1 warning when building kernel with W=1: drivers/isdn/mISDN/layer2.c:463:1: warning: no previous declaration for 'IsRR' [-Wmissing-declarations] In fact, this function is called by no one and not exported, so this patch removes it. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/isdn/mISDN/layer2.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.7.4