diff mbox series

hw/block/tc58128: Don't emit deprecation warning under qtest

Message ID 20240206154151.155620-1-peter.maydell@linaro.org
State Superseded
Headers show
Series hw/block/tc58128: Don't emit deprecation warning under qtest | expand

Commit Message

Peter Maydell Feb. 6, 2024, 3:41 p.m. UTC 
Suppress the deprecation warning when we're running under qtest,
to avoid "make check" including warning messages in its output.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/block/tc58128.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Feb. 6, 2024, 3:51 p.m. UTC | #1 
On 6/2/24 16:41, Peter Maydell wrote:
> Suppress the deprecation warning when we're running under qtest,
> to avoid "make check" including warning messages in its output.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/block/tc58128.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Philippe Mathieu-Daudé Feb. 13, 2024, 6:55 a.m. UTC | #2 
On 6/2/24 16:41, Peter Maydell wrote:
> Suppress the deprecation warning when we're running under qtest,
> to avoid "make check" including warning messages in its output.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/block/tc58128.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)

Patched queued, thanks.
diff mbox series

Patch

diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c
index 6944cf58fa4..0984e37417b 100644
--- a/hw/block/tc58128.c
+++ b/hw/block/tc58128.c
@@ -202,7 +202,9 @@  static sh7750_io_device tc58128 = {
 
 int tc58128_init(struct SH7750State *s, const char *zone1, const char *zone2)
 {
-    warn_report_once("The TC58128 flash device is deprecated");
+    if (!qtest_enabled()) {
+        warn_report_once("The TC58128 flash device is deprecated");
+    }
     init_dev(&tc58128_devs[0], zone1);
     init_dev(&tc58128_devs[1], zone2);
     return sh7750_register_io_device(s, &tc58128);