| Message ID | 20240207163812.3231697-11-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | maintainer updates for 9.0 pre-PR (docker, plugin tests, deprecation, elf, semihosting, gdbstub) | expand |
On 7/2/24 17:38, Alex Bennée wrote: > From: Ilya Leoshkevich <iii@linux.ibm.com> > > The upcoming syscall catchpoint support needs to send SIGTRAP stop > packets to GDB. Being able to compile this support only once for all > targets is a good thing, and it requires hiding TARGET_SIGTRAP behind > a function call. > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > Message-Id: <20240202152506.279476-2-iii@linux.ibm.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > gdbstub/internals.h | 1 + > gdbstub/user-target.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/gdbstub/internals.h b/gdbstub/internals.h > index 5c0c725e54c..aeb0d9b5377 100644 > --- a/gdbstub/internals.h > +++ b/gdbstub/internals.h > @@ -136,6 +136,7 @@ void gdb_append_thread_id(CPUState *cpu, GString *buf); > int gdb_get_cpu_index(CPUState *cpu); > unsigned int gdb_get_max_cpus(void); /* both */ > bool gdb_can_reverse(void); /* softmmu, stub for user */ > +int gdb_target_sigtrap(void); /* user */ > > void gdb_create_default_process(GDBState *s); > > diff --git a/gdbstub/user-target.c b/gdbstub/user-target.c > index c4bba4c72c7..b7d4c37cd81 100644 > --- a/gdbstub/user-target.c > +++ b/gdbstub/user-target.c > @@ -418,3 +418,8 @@ void gdb_handle_query_xfer_exec_file(GArray *params, void *user_ctx) > ts->bprm->filename + offset); > gdb_put_strbuf(); > } > + > +int gdb_target_sigtrap(void) > +{ > + return TARGET_SIGTRAP; > +} Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 5c0c725e54c..aeb0d9b5377 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -136,6 +136,7 @@ void gdb_append_thread_id(CPUState *cpu, GString *buf); int gdb_get_cpu_index(CPUState *cpu); unsigned int gdb_get_max_cpus(void); /* both */ bool gdb_can_reverse(void); /* softmmu, stub for user */ +int gdb_target_sigtrap(void); /* user */ void gdb_create_default_process(GDBState *s); diff --git a/gdbstub/user-target.c b/gdbstub/user-target.c index c4bba4c72c7..b7d4c37cd81 100644 --- a/gdbstub/user-target.c +++ b/gdbstub/user-target.c @@ -418,3 +418,8 @@ void gdb_handle_query_xfer_exec_file(GArray *params, void *user_ctx) ts->bprm->filename + offset); gdb_put_strbuf(); } + +int gdb_target_sigtrap(void) +{ + return TARGET_SIGTRAP; +}