| Message ID | 20240213-msm8996-fix-ufs-v2-6-650758c26458@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: ufs: qcom: fix UFSDHCD support on MSM8996 platform | expand |
On 13.02.2024 12:22, Dmitry Baryshkov wrote: > There is no need to mention and/or to touch in any way the intermediate > (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow > the example lead by all other platforms. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Tue, Feb 13, 2024 at 01:22:22PM +0200, Dmitry Baryshkov wrote: > There is no need to mention and/or to touch in any way the intermediate > (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow > the example lead by all other platforms. > Okay, here you are dropping the "core_clk_unipro_src" anyway. So my earlier comment can be ignored. > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index ce94e2af6bc5..f18d80a97bbf 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -2047,24 +2047,20 @@ ufshc: ufshc@624000 { > power-domains = <&gcc UFS_GDSC>; > > clock-names = > - "core_clk_src", > "core_clk", > "bus_clk", > "bus_aggr_clk", > "iface_clk", > - "core_clk_unipro_src", > "core_clk_unipro", > "core_clk_ice", > "ref_clk", > "tx_lane0_sync_clk", > "rx_lane0_sync_clk"; > clocks = > - <&gcc UFS_AXI_CLK_SRC>, > <&gcc GCC_UFS_AXI_CLK>, > <&gcc GCC_SYS_NOC_UFS_AXI_CLK>, > <&gcc GCC_AGGRE2_UFS_AXI_CLK>, > <&gcc GCC_UFS_AHB_CLK>, > - <&gcc UFS_ICE_CORE_CLK_SRC>, > <&gcc GCC_UFS_UNIPRO_CORE_CLK>, > <&gcc GCC_UFS_ICE_CORE_CLK>, > <&rpmcc RPM_SMD_LN_BB_CLK>, > @@ -2072,8 +2068,6 @@ ufshc: ufshc@624000 { > <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; > freq-table-hz = > <100000000 200000000>, > - <100000000 200000000>, > - <0 0>, > <0 0>, > <0 0>, > <0 0>, > > -- > 2.39.2 >
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index ce94e2af6bc5..f18d80a97bbf 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2047,24 +2047,20 @@ ufshc: ufshc@624000 { power-domains = <&gcc UFS_GDSC>; clock-names = - "core_clk_src", "core_clk", "bus_clk", "bus_aggr_clk", "iface_clk", - "core_clk_unipro_src", "core_clk_unipro", "core_clk_ice", "ref_clk", "tx_lane0_sync_clk", "rx_lane0_sync_clk"; clocks = - <&gcc UFS_AXI_CLK_SRC>, <&gcc GCC_UFS_AXI_CLK>, <&gcc GCC_SYS_NOC_UFS_AXI_CLK>, <&gcc GCC_AGGRE2_UFS_AXI_CLK>, <&gcc GCC_UFS_AHB_CLK>, - <&gcc UFS_ICE_CORE_CLK_SRC>, <&gcc GCC_UFS_UNIPRO_CORE_CLK>, <&gcc GCC_UFS_ICE_CORE_CLK>, <&rpmcc RPM_SMD_LN_BB_CLK>, @@ -2072,8 +2068,6 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <100000000 200000000>, - <0 0>, <0 0>, <0 0>, <0 0>,
There is no need to mention and/or to touch in any way the intermediate (source) clocks. Drop them from MSM8996 UFSHCD schema, making it follow the example lead by all other platforms. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ------ 1 file changed, 6 deletions(-)