| Message ID | 20240213-msm8996-fix-ufs-v2-3-650758c26458@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: ufs: qcom: fix UFSDHCD support on MSM8996 platform | expand |
On 13.02.2024 12:22, Dmitry Baryshkov wrote: > Follow the example of other platforms and specify core_clk frequencies > in the frequency table in addition to the core_clk_src frequencies. The > driver should be setting the leaf frequency instead of some interim > clock freq. > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 80d83e01bb4d..401c6cce9fec 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { > <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; > freq-table-hz = > <100000000 200000000>, > - <0 0>, > + <100000000 200000000>, That's bus_clk, no? Konrad
On Wed, 14 Feb 2024 at 23:24, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 13.02.2024 12:22, Dmitry Baryshkov wrote: > > Follow the example of other platforms and specify core_clk frequencies > > in the frequency table in addition to the core_clk_src frequencies. The > > driver should be setting the leaf frequency instead of some interim > > clock freq. > > > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > index 80d83e01bb4d..401c6cce9fec 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > > @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { > > <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; > > freq-table-hz = > > <100000000 200000000>, > > - <0 0>, > > + <100000000 200000000>, > > That's bus_clk, no? No, it's a core_clk. The "core_clk_src" is removed in one of the next patches. > > Konrad >
On 15.02.2024 09:19, Dmitry Baryshkov wrote: > On Wed, 14 Feb 2024 at 23:24, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 13.02.2024 12:22, Dmitry Baryshkov wrote: >>> Follow the example of other platforms and specify core_clk frequencies >>> in the frequency table in addition to the core_clk_src frequencies. The >>> driver should be setting the leaf frequency instead of some interim >>> clock freq. >>> >>> Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> >>> Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >>> index 80d83e01bb4d..401c6cce9fec 100644 >>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >>> @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { >>> <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; >>> freq-table-hz = >>> <100000000 200000000>, >>> - <0 0>, >>> + <100000000 200000000>, >> >> That's bus_clk, no? > > No, it's a core_clk. The "core_clk_src" is removed in one of the next patches. Just confirmed what you're saying is true, reading the raw diff was apparently not convincing enough for my brain.. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Tue, Feb 13, 2024 at 01:22:19PM +0200, Dmitry Baryshkov wrote: > Follow the example of other platforms and specify core_clk frequencies > in the frequency table in addition to the core_clk_src frequencies. The > driver should be setting the leaf frequency instead of some interim > clock freq. > > Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> > Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 80d83e01bb4d..401c6cce9fec 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { > <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; > freq-table-hz = > <100000000 200000000>, > - <0 0>, > + <100000000 200000000>, > <0 0>, > <0 0>, > <0 0>, > > -- > 2.39.2 >
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 80d83e01bb4d..401c6cce9fec 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2072,7 +2072,7 @@ ufshc: ufshc@624000 { <&gcc GCC_UFS_RX_SYMBOL_0_CLK>; freq-table-hz = <100000000 200000000>, - <0 0>, + <100000000 200000000>, <0 0>, <0 0>, <0 0>,
Follow the example of other platforms and specify core_clk frequencies in the frequency table in addition to the core_clk_src frequencies. The driver should be setting the leaf frequency instead of some interim clock freq. Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com> Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)