| Message ID | 20240214152117.14467-1-a@bayrepo.ru |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: brcmfmac: do not pass hidden SSID attribute as value directly | expand |
On February 14, 2024 4:27:35 PM Alexey Berezhok <a@bayrepo.ru> wrote: > In 'brcmf_cfg80211_start_ap()', not assume that > NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer > an explicit check instead. Use local > variable 'closednet' to pass in function call and > use for error message. Compile tested only. > > Addition for the following patch > > commit f20073f50dfd1 ("wifi: brcmfmac: do not cast hidden SSID > attribute value to boolean") > > Signed-off-by: Alexey Berezhok <a@bayrepo.ru> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > index 63f6e9436..cd6e01f23 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -5269,7 +5269,8 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct > net_device *ndev, > } I think there is some misunderstanding. There is no local variable as I suggested. Here is what I had in mind: bool closednet = settings->hidden_ssid == NL80211_HIDDEN_SSID_NOT_IN_USE; > err = brcmf_fil_iovar_int_set(ifp, "closednet", closednet); > if (err) { > bphy_err(drvr, "%s closednet error (%d)\n", > closednet ? "enabled" : "disabled", err); > -- > 2.39.3
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 63f6e9436..cd6e01f23 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -5269,7 +5269,8 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, } err = brcmf_fil_iovar_int_set(ifp, "closednet", - settings->hidden_ssid); + (settings->hidden_ssid == NL80211_HIDDEN_SSID_NOT_IN_USE) ? + 0 : 1); if (err) { bphy_err(drvr, "%s closednet error (%d)\n", (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
In 'brcmf_cfg80211_start_ap()', not assume that NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer an explicit check instead. Use local variable 'closednet' to pass in function call and use for error message. Compile tested only. Addition for the following patch commit f20073f50dfd1 ("wifi: brcmfmac: do not cast hidden SSID attribute value to boolean") Signed-off-by: Alexey Berezhok <a@bayrepo.ru> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)