| Message ID | 20240215-lp-selftests-fixes-v1-2-89f4a6f5cddc@suse.com |
|---|---|
| State | New |
| Headers | show |
| Series | Improvements to livepatch kselftests on top of kselftest-next | expand |
Hi Marcos, kernel test robot noticed the following build warnings: [auto build test WARNING on 345e8abe4c355bc24bab3f4a5634122e55be8665] url: https://github.com/intel-lab-lkp/linux/commits/Marcos-Paulo-de-Souza/selftests-lib-mk-Do-not-process-TEST_GEN_MODS_DIR/20240216-021601 base: 345e8abe4c355bc24bab3f4a5634122e55be8665 patch link: https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-2-89f4a6f5cddc%40suse.com patch subject: [PATCH 2/3] selftests: lib.mk: Simplify TEST_GEN_MODS_DIR handling compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191502.dALlSRz0-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202402191502.dALlSRz0-lkp@intel.com/ All warnings (new ones prefixed by >>): >> Makefile:11: warning: overriding recipe for target 'all' >> ../lib.mk:62: warning: ignoring old recipe for target 'all' make[1]: *** [../lib.mk:62: all] Error 2 Makefile:65: warning: overriding recipe for target 'emit_tests' ../lib.mk:120: warning: ignoring old recipe for target 'emit_tests' make[1]: *** No targets. Stop. make[1]: *** No targets. Stop. make[1]: *** No targets. Stop. vim +/all +11 Makefile ^1da177e4c3f41 Linus Torvalds 2005-04-16 7 ^1da177e4c3f41 Linus Torvalds 2005-04-16 8 # *DOCUMENTATION* ^1da177e4c3f41 Linus Torvalds 2005-04-16 9 # To see a list of typical targets execute "make help" ^1da177e4c3f41 Linus Torvalds 2005-04-16 10 # More info can be located in ./README ^1da177e4c3f41 Linus Torvalds 2005-04-16 @11 # Comments in this file are targeted only to the developer, do not ^1da177e4c3f41 Linus Torvalds 2005-04-16 12 # expect to learn how to build the kernel reading this file. ^1da177e4c3f41 Linus Torvalds 2005-04-16 13
On Mon, 19 Feb 2024 15:16:51 +0800 kernel test robot <lkp@intel.com> wrote: > Hi Marcos, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on 345e8abe4c355bc24bab3f4a5634122e55be8665] > > url: https://github.com/intel-lab-lkp/linux/commits/Marcos-Paulo-de-Souza/selftests-lib-mk-Do-not-process-TEST_GEN_MODS_DIR/20240216-021601 > base: 345e8abe4c355bc24bab3f4a5634122e55be8665 > patch link: https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-2-89f4a6f5cddc%40suse.com > patch subject: [PATCH 2/3] selftests: lib.mk: Simplify TEST_GEN_MODS_DIR handling > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191502.dALlSRz0-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202402191502.dALlSRz0-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> Makefile:11: warning: overriding recipe for target 'all' > >> ../lib.mk:62: warning: ignoring old recipe for target 'all' > make[1]: *** [../lib.mk:62: all] Error 2 > Makefile:65: warning: overriding recipe for target 'emit_tests' > ../lib.mk:120: warning: ignoring old recipe for target 'emit_tests' > make[1]: *** No targets. Stop. > make[1]: *** No targets. Stop. > make[1]: *** No targets. Stop. I couldn't reproduce this one locally. Shuah, have you seen this issue in your setup? I followed the steps to reproduce this issue (it's the same sequence already reported in earlier patches...) > > > vim +/all +11 Makefile > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 7 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 8 # *DOCUMENTATION* > ^1da177e4c3f41 Linus Torvalds 2005-04-16 9 # To see a list of typical targets execute "make help" > ^1da177e4c3f41 Linus Torvalds 2005-04-16 10 # More info can be located in ./README > ^1da177e4c3f41 Linus Torvalds 2005-04-16 @11 # Comments in this file are targeted only to the developer, do not > ^1da177e4c3f41 Linus Torvalds 2005-04-16 12 # expect to learn how to build the kernel reading this file. > ^1da177e4c3f41 Linus Torvalds 2005-04-16 13 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki
On Wed, Feb 21, 2024 at 09:29:47AM -0300, Marcos Paulo de Souza wrote: > On Mon, 19 Feb 2024 15:16:51 +0800 kernel test robot <lkp@intel.com> wrote: > > > Hi Marcos, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on 345e8abe4c355bc24bab3f4a5634122e55be8665] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Marcos-Paulo-de-Souza/selftests-lib-mk-Do-not-process-TEST_GEN_MODS_DIR/20240216-021601 > > base: 345e8abe4c355bc24bab3f4a5634122e55be8665 > > patch link: https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-2-89f4a6f5cddc%40suse.com > > patch subject: [PATCH 2/3] selftests: lib.mk: Simplify TEST_GEN_MODS_DIR handling > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240219/202402191502.dALlSRz0-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@intel.com> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202402191502.dALlSRz0-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> Makefile:11: warning: overriding recipe for target 'all' > > >> ../lib.mk:62: warning: ignoring old recipe for target 'all' > > I couldn't reproduce this one locally. Shuah, have you seen this issue in your > setup? I followed the steps to reproduce this issue (it's the same sequence > already reported in earlier patches...) Hi Marcos, This seems to be a warning when compiling futex selftest. linux/tools/testing/selftests/futex$ make Makefile:11: warning: overriding recipe for target 'all' ../lib.mk:62: warning: ignoring old recipe for target 'all' There is no such warning if this patch is not applied. Looks like it is due to the "all" target is defined in lib.mk but overridden in futex Makefile? Could you please help take a look? Thanks, Yujie
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 286ce0ee102b..eddcd4a849dc 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -58,8 +58,9 @@ TEST_GEN_PROGS := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS)) TEST_GEN_PROGS_EXTENDED := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_PROGS_EXTENDED)) TEST_GEN_FILES := $(patsubst %,$(OUTPUT)/%,$(TEST_GEN_FILES)) -all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) \ - $(if $(TEST_GEN_MODS_DIR),gen_mods_dir) +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) + $(if $(TEST_GEN_MODS_DIR), \ + $(Q)$(MAKE) -C $(TEST_GEN_MODS_DIR)) define RUN_TESTS BASE_DIR="$(selfdir)"; \ @@ -85,11 +86,6 @@ else @$(call RUN_TESTS, $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS)) endif -gen_mods_dir: - $(Q)$(MAKE) -C $(TEST_GEN_MODS_DIR) - -clean_mods_dir: - $(Q)$(MAKE) -C $(TEST_GEN_MODS_DIR) clean define INSTALL_SINGLE_RULE $(if $(INSTALL_LIST),@mkdir -p $(INSTALL_PATH)) @@ -133,9 +129,11 @@ endif define CLEAN $(RM) -r $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) $(EXTRA_CLEAN) + $(if $(TEST_GEN_MODS_DIR), \ + $(Q)$(MAKE) -C $(TEST_GEN_MODS_DIR) clean) endef -clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir) +clean: $(CLEAN) # Enables to extend CFLAGS and LDFLAGS from command line, e.g. @@ -166,4 +164,4 @@ $(OUTPUT)/%:%.S $(LINK.S) $^ $(LDLIBS) -o $@ endif -.PHONY: run_tests all clean install emit_tests gen_mods_dir clean_mods_dir +.PHONY: run_tests all clean install emit_tests
We don't need new targets only to run two make modules and make clean. We can test if TEST_GEN_MODS_DIR is specified, and then run the commands. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> --- tools/testing/selftests/lib.mk | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)