diff mbox series

wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro

Message ID 20240216213649.251718-1-hdegoede@redhat.com
State New
Headers show
Series wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro | expand

Commit Message

Hans de Goede Feb. 16, 2024, 9:36 p.m. UTC
The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
and product_name DMI strings, without this patch brcmfmac will try to load:
"brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
which is both too generic and messy with the $ symbols in the name.

The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
and the nvram for the T8 is already in linux-firmware, so point the new
DMI nvram filename quirk to the T8 nvram file.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Arend van Spriel Feb. 17, 2024, 9:53 p.m. UTC | #1
On February 16, 2024 10:37:06 PM Hans de Goede <hdegoede@redhat.com> wrote:

> The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
> which is both too generic and messy with the $ symbols in the name.
>
> The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
> and the nvram for the T8 is already in linux-firmware, so point the new
> DMI nvram filename quirk to the T8 nvram file.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Kalle Valo Feb. 21, 2024, 6:56 p.m. UTC | #2
Hans de Goede <hdegoede@redhat.com> wrote:

> The ACEPC W5 Pro HDMI stick contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.$(DEFAULT_STRING)-$(DEFAULT_STRING).txt" as nvram file
> which is both too generic and messy with the $ symbols in the name.
> 
> The ACEPC W5 Pro uses the same Ampak AP6255 module as the ACEPC T8
> and the nvram for the T8 is already in linux-firmware, so point the new
> DMI nvram filename quirk to the T8 nvram file.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Patch applied to wireless-next.git, thanks.

32167707aa5e wifi: brcmfmac: Add DMI nvram filename quirk for ACEPC W5 Pro
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index 86ff174936a9..c3a602197662 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -82,6 +82,15 @@  static const struct dmi_system_id dmi_platform_data[] = {
 		},
 		.driver_data = (void *)&acepc_t8_data,
 	},
+	{
+		/* ACEPC W5 Pro Cherry Trail Z8350 HDMI stick, same wifi as the T8 */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "T3 MRD"),
+			DMI_MATCH(DMI_CHASSIS_TYPE, "3"),
+			DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
+		},
+		.driver_data = (void *)&acepc_t8_data,
+	},
 	{
 		/* Chuwi Hi8 Pro with D2D3_Hi8Pro.233 BIOS */
 		.matches = {